[Bf-blender-cvs] [eb54502d9d2] master: Fix T101109: Animation on nodes problems when dealing with Node Groups

Philipp Oeser noreply at git.blender.org
Fri Sep 23 12:08:55 CEST 2022


Commit: eb54502d9d29b18cbeda22125a601f3ce0bc423e
Author: Philipp Oeser
Date:   Fri Sep 16 13:04:54 2022 +0200
Branches: master
https://developer.blender.org/rBeb54502d9d29b18cbeda22125a601f3ce0bc423e

Fix T101109: Animation on nodes problems when dealing with Node Groups

Whenever animation on nodes was transfered to/from nodegroups (grouping/
ungrouping/separating) via BKE_animdata_transfer_by_basepath, it was
possible to create new nodes with the same name (in the formerly same
path -- see report for an example of this) and animation from the
original node was still performed on them. Issue went away after save/
reload.

In order to fully update the action, a depsgraph is now performed on the
action (similar to what is done when renaming for example).

Maniphest Tasks: T101109

Differential Revision: https://developer.blender.org/D15987

===================================================================

M	source/blender/blenkernel/intern/anim_data.c

===================================================================

diff --git a/source/blender/blenkernel/intern/anim_data.c b/source/blender/blenkernel/intern/anim_data.c
index 65ce3e3b523..9b68c19c6e2 100644
--- a/source/blender/blenkernel/intern/anim_data.c
+++ b/source/blender/blenkernel/intern/anim_data.c
@@ -659,6 +659,8 @@ void BKE_animdata_transfer_by_basepath(Main *bmain, ID *srcID, ID *dstID, ListBa
           srcAdt, dstAdt, basepath_change->src_basepath, basepath_change->dst_basepath);
     }
   }
+  /* Tag source action because list of fcurves changed. */
+  DEG_id_tag_update(&srcAdt->action->id, ID_RECALC_COPY_ON_WRITE);
 }
 
 /* Path Validation -------------------------------------------- */



More information about the Bf-blender-cvs mailing list