[Bf-blender-cvs] [20dc8393192] master: Fix T101262: Crash in spreadsheet selection filter with empty domain

Hans Goudey noreply at git.blender.org
Thu Sep 22 00:34:38 CEST 2022


Commit: 20dc8393192fcf5e5183816134436c1e871b852d
Author: Hans Goudey
Date:   Wed Sep 21 17:34:30 2022 -0500
Branches: master
https://developer.blender.org/rB20dc8393192fcf5e5183816134436c1e871b852d

Fix T101262: Crash in spreadsheet selection filter with empty domain

The BMesh selection virtual array was empty. There are a few different
places we could add an "empty" check here, but at the top of the
function is the simplest for now.

===================================================================

M	source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc

===================================================================

diff --git a/source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc b/source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc
index 4703eacdcb9..fd2ac4d39a1 100644
--- a/source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc
+++ b/source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc
@@ -271,6 +271,9 @@ IndexMask GeometryDataSource::apply_selection_filter(Vector<int64_t> &indices) c
 {
   std::lock_guard lock{mutex_};
   const IndexMask full_range(this->tot_rows());
+  if (full_range.is_empty()) {
+    return full_range;
+  }
 
   switch (component_->type()) {
     case GEO_COMPONENT_TYPE_MESH: {



More information about the Bf-blender-cvs mailing list