[Bf-blender-cvs] [bcdb90b9618] blender-v3.3-release: Fix: Spreadsheet row filters unimplemented for boolean type

Hans Goudey noreply at git.blender.org
Wed Sep 21 14:27:09 CEST 2022


Commit: bcdb90b96189cc9634f906ec00dd49f17718971b
Author: Hans Goudey
Date:   Wed Sep 7 23:31:46 2022 -0500
Branches: blender-v3.3-release
https://developer.blender.org/rBbcdb90b96189cc9634f906ec00dd49f17718971b

Fix: Spreadsheet row filters unimplemented for boolean type

This was lost in 474adc6f883c2d5a85

===================================================================

M	source/blender/editors/space_spreadsheet/spreadsheet_row_filter.cc

===================================================================

diff --git a/source/blender/editors/space_spreadsheet/spreadsheet_row_filter.cc b/source/blender/editors/space_spreadsheet/spreadsheet_row_filter.cc
index 6806e185cfe..03cf0116dce 100644
--- a/source/blender/editors/space_spreadsheet/spreadsheet_row_filter.cc
+++ b/source/blender/editors/space_spreadsheet/spreadsheet_row_filter.cc
@@ -71,6 +71,14 @@ static void apply_row_filter(const SpreadsheetRowFilter &row_filter,
       }
     }
   }
+  else if (column_data.type().is<bool>()) {
+    const bool value = (row_filter.flag & SPREADSHEET_ROW_FILTER_BOOL_VALUE) != 0;
+    apply_filter_operation(
+        column_data.typed<bool>(),
+        [&](const bool cell) { return cell == value; },
+        prev_mask,
+        new_indices);
+  }
   else if (column_data.type().is<int8_t>()) {
     const int value = row_filter.value_int;
     switch (row_filter.operation) {
@@ -274,7 +282,6 @@ static void apply_row_filter(const SpreadsheetRowFilter &row_filter,
   }
   else if (column_data.type().is<InstanceReference>()) {
     const StringRef value = row_filter.value_string;
-
     apply_filter_operation(
         column_data.typed<InstanceReference>(),
         [&](const InstanceReference cell) {



More information about the Bf-blender-cvs mailing list