[Bf-blender-cvs] [fc0e7062d72] temp-T73411-view-layer-lazy-cache: Remove todos
Monique
noreply at git.blender.org
Thu Sep 8 11:58:39 CEST 2022
Commit: fc0e7062d720a1d01e23aec42df03a97754000fe
Author: Monique
Date: Thu Sep 8 10:56:58 2022 +0200
Branches: temp-T73411-view-layer-lazy-cache
https://developer.blender.org/rBfc0e7062d720a1d01e23aec42df03a97754000fe
Remove todos
===================================================================
M source/blender/blenloader/intern/readfile.c
M source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
M source/blender/makesrna/intern/rna_layer.c
===================================================================
diff --git a/source/blender/blenloader/intern/readfile.c b/source/blender/blenloader/intern/readfile.c
index ff10d0a59b5..863f978daaf 100644
--- a/source/blender/blenloader/intern/readfile.c
+++ b/source/blender/blenloader/intern/readfile.c
@@ -2468,7 +2468,6 @@ static void lib_link_window_scene_data_restore(wmWindow *win, Scene *scene, View
/* Local-view can become invalid during undo/redo steps,
* so we exit it when no could be found. */
- // TODO: Use BKE_view_layer_object_bases_get here?
for (base = view_layer->object_bases.first; base; base = base->next) {
if (base->local_view_bits & v3d->local_view_uuid) {
break;
diff --git a/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc b/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
index b800897b8c9..4fc0f5b94d8 100644
--- a/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
+++ b/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
@@ -456,7 +456,7 @@ void view_layer_update_orig_base_pointers(const ViewLayer *view_layer_orig,
/* Happens when scene is only used for parameters or compositor/sequencer. */
return;
}
- // TODO: BKE_view_layer_object_bases_get this should be fine, but check just in case.
+
Base *base_orig = reinterpret_cast<Base *>(view_layer_orig->object_bases.first);
LISTBASE_FOREACH (Base *, base_eval, &view_layer_eval->object_bases) {
base_eval->base_orig = base_orig;
diff --git a/source/blender/makesrna/intern/rna_layer.c b/source/blender/makesrna/intern/rna_layer.c
index dc1191293b7..bdd5b822db8 100644
--- a/source/blender/makesrna/intern/rna_layer.c
+++ b/source/blender/makesrna/intern/rna_layer.c
@@ -564,7 +564,6 @@ void RNA_def_view_layer(BlenderRNA *brna)
prop = RNA_def_property(srna, "objects", PROP_COLLECTION, PROP_NONE);
RNA_def_property_collection_sdna(prop, NULL, "object_bases", NULL);
RNA_def_property_struct_type(prop, "Object");
- // TODO: Use BKE_view_layer_object_bases_get?
RNA_def_property_collection_funcs(
prop, NULL, NULL, NULL, "rna_ViewLayer_objects_get", NULL, NULL, NULL, NULL);
RNA_def_property_ui_text(prop, "Objects", "All the objects in this layer");
More information about the Bf-blender-cvs
mailing list