[Bf-blender-cvs] [c69b3041291] tmp-workbench-rewrite2: update TODO info

Miguel Pozo noreply at git.blender.org
Mon Oct 31 17:19:43 CET 2022


Commit: c69b30412915c961ac56002bdf56d3f9002fc5e5
Author: Miguel Pozo
Date:   Mon Oct 31 17:19:37 2022 +0100
Branches: tmp-workbench-rewrite2
https://developer.blender.org/rBc69b30412915c961ac56002bdf56d3f9002fc5e5

update TODO info

===================================================================

M	source/blender/draw/engines/workbench/workbench_mesh_passes.cc

===================================================================

diff --git a/source/blender/draw/engines/workbench/workbench_mesh_passes.cc b/source/blender/draw/engines/workbench/workbench_mesh_passes.cc
index 24936daa4c8..11961b5ff8f 100644
--- a/source/blender/draw/engines/workbench/workbench_mesh_passes.cc
+++ b/source/blender/draw/engines/workbench/workbench_mesh_passes.cc
@@ -72,7 +72,9 @@ PassMain::Sub &MeshPass::sub_pass_get(ObjectRef &ref,
         }
         sub_pass->push_constant("isImageTile", tilemap != nullptr);
         sub_pass->push_constant("imagePremult", image && image->alpha_mode == IMA_ALPHA_PREMUL);
-        /*TODO(Miguel Pozo): This setting should be set per Material. */
+        /* TODO(Miguel Pozo): This setting should be exposed on the user side,
+         * either as a global parameter (and set it here)
+         * or by reading the Material Clipping Threshold (and set it per material) */
         sub_pass->push_constant("imageTransparencyCutoff", 0.1f);
         return sub_pass;
       };



More information about the Bf-blender-cvs mailing list