[Bf-blender-cvs] [c2e36c09b99] master: Fix variable value assigned twice in succession

Germano Cavalcante noreply at git.blender.org
Mon Oct 31 10:54:11 CET 2022


Commit: c2e36c09b993fc0678eaf6a65b2cbd8ea9132cdb
Author: Germano Cavalcante
Date:   Mon Oct 31 06:54:17 2022 -0300
Branches: master
https://developer.blender.org/rBc2e36c09b993fc0678eaf6a65b2cbd8ea9132cdb

Fix variable value assigned twice in succession

Error introduced in rBa7aa0f1a0c24

Mentioned in https://pvs-studio.com/en/blog/posts/cpp/1004/

It could cause the absolute snap to the y direction to fail in
some editor.

===================================================================

M	source/blender/editors/transform/transform.c

===================================================================

diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c
index 5b194ae7237..ad6ab625438 100644
--- a/source/blender/editors/transform/transform.c
+++ b/source/blender/editors/transform/transform.c
@@ -1725,7 +1725,7 @@ static void initSnapSpatial(TransInfo *t, float r_snap[3], float *r_snap_precisi
 {
   /* Default values. */
   r_snap[0] = r_snap[1] = 1.0f;
-  r_snap[1] = 0.0f;
+  r_snap[2] = 0.0f;
   *r_snap_precision = 0.1f;
 
   if (t->spacetype == SPACE_VIEW3D) {



More information about the Bf-blender-cvs mailing list