[Bf-blender-cvs] [fb424db2b7b] master: Fix T99603: node body colors colormanagement issue

Philipp Oeser noreply at git.blender.org
Tue Oct 25 14:07:17 CEST 2022


Commit: fb424db2b7bb95a6d917d1aa562609682123274a
Author: Philipp Oeser
Date:   Tue Oct 25 12:14:39 2022 +0200
Branches: master
https://developer.blender.org/rBfb424db2b7bb95a6d917d1aa562609682123274a

Fix T99603: node body colors colormanagement issue

This led to the color actually looking different on the node body itself
vs. in the panel, also using the colorpicker gave unexpected results.

UI colors should use PROP_COLOR_GAMMA to avoid being affected by scene
color management (clarification by @brecht).

Maniphest Tasks: T99603

Differential Revision: https://developer.blender.org/D16334

===================================================================

M	source/blender/makesrna/intern/rna_nodetree.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_nodetree.c b/source/blender/makesrna/intern/rna_nodetree.c
index 0b0970a835e..865399df9ef 100644
--- a/source/blender/makesrna/intern/rna_nodetree.c
+++ b/source/blender/makesrna/intern/rna_nodetree.c
@@ -12230,7 +12230,7 @@ static void rna_def_node(BlenderRNA *brna)
   RNA_def_property_ui_text(prop, "Custom Color", "Use custom color for the node");
   RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, NULL);
 
-  prop = RNA_def_property(srna, "color", PROP_FLOAT, PROP_COLOR);
+  prop = RNA_def_property(srna, "color", PROP_FLOAT, PROP_COLOR_GAMMA);
   RNA_def_property_array(prop, 3);
   RNA_def_property_range(prop, 0.0f, 1.0f);
   RNA_def_property_ui_text(prop, "Color", "Custom color of the node body");



More information about the Bf-blender-cvs mailing list