[Bf-blender-cvs] [9f560219751] master: Fix T101930: NLA Actions Stash remove doesn't work on overriden linked data.

Bastien Montagne noreply at git.blender.org
Sat Oct 22 17:24:55 CEST 2022


Commit: 9f560219751240cc15a8de0b2e485e1538fee642
Author: Bastien Montagne
Date:   Sat Oct 22 17:19:55 2022 +0200
Branches: master
https://developer.blender.org/rB9f560219751240cc15a8de0b2e485e1538fee642

Fix T101930: NLA Actions Stash remove doesn't work on overriden linked data.

Code adding stash track was clearing out track flags, instead of editing
them as it should have...

Note that there are a lot of other weaknesses in action stash code (like
relying on the (translated!!!!!!) name of the track to know whether it's
a stah or not).

===================================================================

M	source/blender/blenkernel/intern/nla.c

===================================================================

diff --git a/source/blender/blenkernel/intern/nla.c b/source/blender/blenkernel/intern/nla.c
index ba63cdff917..24663d6db05 100644
--- a/source/blender/blenkernel/intern/nla.c
+++ b/source/blender/blenkernel/intern/nla.c
@@ -1918,7 +1918,7 @@ bool BKE_nla_action_stash(AnimData *adt, const bool is_liboverride)
    * NOTE: this must be done *after* adding the strip to the track, or else
    *       the strip locking will prevent the strip from getting added
    */
-  nlt->flag = (NLATRACK_MUTED | NLATRACK_PROTECTED);
+  nlt->flag |= (NLATRACK_MUTED | NLATRACK_PROTECTED);
   strip->flag &= ~(NLASTRIP_FLAG_SELECT | NLASTRIP_FLAG_ACTIVE);
 
   /* also mark the strip for auto syncing the length, so that the strips accurately



More information about the Bf-blender-cvs mailing list