[Bf-blender-cvs] [b9b4b35096b] temp-T101905-gpu-backend-argument: Add support for animation playback.

Jeroen Bakker noreply at git.blender.org
Wed Oct 19 10:56:32 CEST 2022


Commit: b9b4b35096bab1c110b6e5b3a5f350e6008b6028
Author: Jeroen Bakker
Date:   Wed Oct 19 10:42:29 2022 +0200
Branches: temp-T101905-gpu-backend-argument
https://developer.blender.org/rBb9b4b35096bab1c110b6e5b3a5f350e6008b6028

Add support for animation playback.

===================================================================

M	source/blender/windowmanager/intern/wm_playanim.c
M	source/creator/creator_args.c

===================================================================

diff --git a/source/blender/windowmanager/intern/wm_playanim.c b/source/blender/windowmanager/intern/wm_playanim.c
index cb52ffd9c7c..3e5399a6f56 100644
--- a/source/blender/windowmanager/intern/wm_playanim.c
+++ b/source/blender/windowmanager/intern/wm_playanim.c
@@ -1342,7 +1342,6 @@ static bool ghost_event_proc(GHOST_EventHandle evt, GHOST_TUserDataPtr ps_void)
 static void playanim_window_open(const char *title, int posx, int posy, int sizex, int sizey)
 {
   GHOST_GLSettings glsettings = {0};
-  /* TODO selection should be done based on the GPU backend. Same as wm_window_*/
   const eGPUBackendType gpu_backend = GPU_backend_type_selection_get();
   glsettings.context_type = wm_ghost_drawing_context_type(gpu_backend);
   uint32_t scr_w, scr_h;
diff --git a/source/creator/creator_args.c b/source/creator/creator_args.c
index b333950134b..b4ea51c2c7f 100644
--- a/source/creator/creator_args.c
+++ b/source/creator/creator_args.c
@@ -2109,6 +2109,10 @@ void main_args_setup(bContext *C, bArgs *ba)
   BLI_args_add(ba, NULL, "--log-show-timestamp", CB(arg_handle_log_show_timestamp_set), ba);
   BLI_args_add(ba, NULL, "--log-file", CB(arg_handle_log_file_set), ba);
 
+  /* GPU backend selection should be part of ARG_PASS_ENVIRONMENT for correct GPU context selection
+   * for anim player. */
+  BLI_args_add(ba, NULL, "--gpu-backend", CB(arg_handle_gpu_backend_set), NULL);
+
   /* Pass: Background Mode & Settings
    *
    * Also and commands that exit after usage. */
@@ -2281,7 +2285,6 @@ void main_args_setup(bContext *C, bArgs *ba)
   BLI_args_add(ba, "-R", NULL, CB(arg_handle_register_extension), NULL);
   BLI_args_add(ba, "-r", NULL, CB_EX(arg_handle_register_extension, silent), ba);
   BLI_args_add(ba, NULL, "--no-native-pixels", CB(arg_handle_native_pixels_set), ba);
-  BLI_args_add(ba, NULL, "--gpu-backend", CB(arg_handle_gpu_backend_set), NULL);
 
   /* Pass: Disabling Things & Forcing Settings. */
   BLI_args_pass_set(ba, ARG_PASS_SETTINGS_FORCE);



More information about the Bf-blender-cvs mailing list