[Bf-blender-cvs] [695614ad3b7] master: Fix T101805: Blender icons doesn't show in GNOME 43

Campbell Barton noreply at git.blender.org
Fri Oct 14 07:55:50 CEST 2022


Commit: 695614ad3b7afb95b9918081d9e2c8e1ddd87f5e
Author: Campbell Barton
Date:   Fri Oct 14 16:53:41 2022 +1100
Branches: master
https://developer.blender.org/rB695614ad3b7afb95b9918081d9e2c8e1ddd87f5e

Fix T101805: Blender icons doesn't show in GNOME 43

Use an app_id that matches the naming for the `.desktop`
file distributed with Blender.

Follow up to T101779.

===================================================================

M	intern/ghost/intern/GHOST_WindowWayland.cpp

===================================================================

diff --git a/intern/ghost/intern/GHOST_WindowWayland.cpp b/intern/ghost/intern/GHOST_WindowWayland.cpp
index 306739e5d78..5f9202f1227 100644
--- a/intern/ghost/intern/GHOST_WindowWayland.cpp
+++ b/intern/ghost/intern/GHOST_WindowWayland.cpp
@@ -497,8 +497,14 @@ GHOST_WindowWayland::GHOST_WindowWayland(GHOST_SystemWayland *system,
    * when the `w->scale` changed. */
   const int32_t size_min[2] = {320, 240};
 
-  /* This value is expected to match the base name of the `.desktop` file. see T101779. */
-  const char *xdg_app_id = "org.blender.Blender";
+  /* This value is expected to match the base name of the `.desktop` file. see T101805.
+   *
+   * NOTE: the XDG desktop-entry-spec defines that this should follow the "reverse DNS" convention.
+   * For e.g. `org.blender.Blender` - however the `.desktop` file distributed with Blender is
+   * simply called `blender.desktop`, so the it's important to follow that name.
+   * Other distributions such as SNAP & FLATPAK may need to change this value T101779.
+   * Currently there isn't a way to configure this, we may want to support that. */
+  const char *xdg_app_id = "blender";
 
 #ifdef WITH_GHOST_WAYLAND_LIBDECOR
   if (use_libdecor) {



More information about the Bf-blender-cvs mailing list