[Bf-blender-cvs] [e46c6650e34] soc-2022-many-lights-sampling: Fix access before initialization error in last fix

Weizhen Huang noreply at git.blender.org
Tue Nov 29 18:53:10 CET 2022


Commit: e46c6650e3465e4647351d22ffc91940362f3782
Author: Weizhen Huang
Date:   Tue Nov 29 18:50:09 2022 +0100
Branches: soc-2022-many-lights-sampling
https://developer.blender.org/rBe46c6650e3465e4647351d22ffc91940362f3782

Fix access before initialization error in last fix

===================================================================

M	intern/cycles/kernel/light/point.h

===================================================================

diff --git a/intern/cycles/kernel/light/point.h b/intern/cycles/kernel/light/point.h
index bf85877e373..e88a8ecbaa0 100644
--- a/intern/cycles/kernel/light/point.h
+++ b/intern/cycles/kernel/light/point.h
@@ -125,8 +125,8 @@ ccl_device_forceinline bool point_light_tree_parameters(const ccl_global KernelL
   point_to_centroid = safe_normalize_len(centroid - P, &min_distance);
 
   const float radius = klight->spot.radius;
-  const float hypotenus = sqrtf(sqr(radius) + sqr(distance.y));
-  cos_theta_u = distance.y / hypotenus;
+  const float hypotenus = sqrtf(sqr(radius) + sqr(min_distance));
+  cos_theta_u = min_distance / hypotenus;
 
   distance = make_float2(hypotenus, min_distance);



More information about the Bf-blender-cvs mailing list