[Bf-blender-cvs] [d2b74943ce0] blender-v3.3-release: Fix T99603: node body colors colormanagement issue

Philipp Oeser noreply at git.blender.org
Mon Nov 28 13:43:38 CET 2022


Commit: d2b74943ce0197f349ea2578b5c375ba59bf3c42
Author: Philipp Oeser
Date:   Tue Oct 25 12:14:39 2022 +0200
Branches: blender-v3.3-release
https://developer.blender.org/rBd2b74943ce0197f349ea2578b5c375ba59bf3c42

Fix T99603: node body colors colormanagement issue

This led to the color actually looking different on the node body itself
vs. in the panel, also using the colorpicker gave unexpected results.

UI colors should use PROP_COLOR_GAMMA to avoid being affected by scene
color management (clarification by @brecht).

Maniphest Tasks: T99603

Differential Revision: https://developer.blender.org/D16334

===================================================================

M	source/blender/makesrna/intern/rna_nodetree.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_nodetree.c b/source/blender/makesrna/intern/rna_nodetree.c
index 27503a9a45a..98bd3705455 100644
--- a/source/blender/makesrna/intern/rna_nodetree.c
+++ b/source/blender/makesrna/intern/rna_nodetree.c
@@ -12122,7 +12122,7 @@ static void rna_def_node(BlenderRNA *brna)
   RNA_def_property_ui_text(prop, "Custom Color", "Use custom color for the node");
   RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, NULL);
 
-  prop = RNA_def_property(srna, "color", PROP_FLOAT, PROP_COLOR);
+  prop = RNA_def_property(srna, "color", PROP_FLOAT, PROP_COLOR_GAMMA);
   RNA_def_property_array(prop, 3);
   RNA_def_property_range(prop, 0.0f, 1.0f);
   RNA_def_property_ui_text(prop, "Color", "Custom color of the node body");



More information about the Bf-blender-cvs mailing list