[Bf-blender-cvs] [89ca2982104] master: Cleanup: Don't set mesh normals directly for metaballs

Hans Goudey noreply at git.blender.org
Wed Nov 16 19:58:12 CET 2022


Commit: 89ca29821043874e57e5c1ca6e07210bf5bb51e4
Author: Hans Goudey
Date:   Wed Nov 16 12:37:35 2022 -0600
Branches: master
https://developer.blender.org/rB89ca29821043874e57e5c1ca6e07210bf5bb51e4

Cleanup: Don't set mesh normals directly for metaballs

At the cost of a memory copy, this allows using a C++ type to store
normals in mesh runtime data in upcoming patches.

===================================================================

M	source/blender/blenkernel/intern/mball_tessellate.cc

===================================================================

diff --git a/source/blender/blenkernel/intern/mball_tessellate.cc b/source/blender/blenkernel/intern/mball_tessellate.cc
index f8a64a7cd8b..c2322da19cb 100644
--- a/source/blender/blenkernel/intern/mball_tessellate.cc
+++ b/source/blender/blenkernel/intern/mball_tessellate.cc
@@ -1499,7 +1499,10 @@ Mesh *BKE_mball_polygonize(Depsgraph *depsgraph, Scene *scene, Object *ob)
   for (int i = 0; i < mesh->totvert; i++) {
     normalize_v3(process.no[i]);
   }
-  mesh->runtime->vert_normals = process.no;
+  memcpy(BKE_mesh_vertex_normals_for_write(mesh),
+         process.no,
+         sizeof(float[3]) * size_t(mesh->totvert));
+  MEM_freeN(process.no);
   BKE_mesh_vertex_normals_clear_dirty(mesh);
 
   mesh->totloop = loop_offset;



More information about the Bf-blender-cvs mailing list