[Bf-blender-cvs] [16f5cda14ad] temp-ghost-vulkan: Removed obsolete comments.

Jeroen Bakker noreply at git.blender.org
Tue Nov 1 08:43:09 CET 2022


Commit: 16f5cda14ada1963b90c7ca0930ddf49efd62cb9
Author: Jeroen Bakker
Date:   Fri Oct 21 13:10:58 2022 +0200
Branches: temp-ghost-vulkan
https://developer.blender.org/rB16f5cda14ada1963b90c7ca0930ddf49efd62cb9

Removed obsolete comments.

===================================================================

M	intern/ghost/intern/GHOST_ContextVK.cpp

===================================================================

diff --git a/intern/ghost/intern/GHOST_ContextVK.cpp b/intern/ghost/intern/GHOST_ContextVK.cpp
index fb91505fdc7..3446f7e71f8 100644
--- a/intern/ghost/intern/GHOST_ContextVK.cpp
+++ b/intern/ghost/intern/GHOST_ContextVK.cpp
@@ -419,7 +419,6 @@ static bool device_extensions_support(VkPhysicalDevice device, vector<const char
 
 GHOST_TSuccess GHOST_ContextVK::pickPhysicalDevice(vector<const char *> required_exts)
 {
-  /* TODO Pick the best GPU by default OR by name from user settings. */
   m_physical_device = VK_NULL_HANDLE;
 
   uint32_t device_count = 0;
@@ -446,7 +445,6 @@ GHOST_TSuccess GHOST_ContextVK::pickPhysicalDevice(vector<const char *> required
     if (m_surface != VK_NULL_HANDLE) {
       uint32_t format_count;
       vkGetPhysicalDeviceSurfaceFormatsKHR(physical_device, m_surface, &format_count, NULL);
-      /* TODO(fclem) This is where we should check for HDR surface format. */
 
       uint32_t present_count;
       vkGetPhysicalDeviceSurfacePresentModesKHR(physical_device, m_surface, &present_count, NULL);
@@ -538,8 +536,6 @@ static GHOST_TSuccess getPresetQueueFamily(VkPhysicalDevice device,
   vector<VkQueueFamilyProperties> queue_families(queue_family_count);
   vkGetPhysicalDeviceQueueFamilyProperties(device, &queue_family_count, queue_families.data());
 
-  /* TODO(fclem) Prefer using the familly who also has graphic ability.
-   * These may not be the same. */
   *r_queue_index = 0;
   for (int i = 0; i < queue_family_count; i++) {
     VkBool32 present_support = false;
@@ -643,8 +639,6 @@ GHOST_TSuccess GHOST_ContextVK::recordCommandBuffers(void)
 
       vkCmdBeginRenderPass(m_command_buffers[i], &render_pass_info, VK_SUBPASS_CONTENTS_INLINE);
 
-      /* TODO draw something. */
-
       vkCmdEndRenderPass(m_command_buffers[i]);
     }
     VK_CHECK(vkEndCommandBuffer(m_command_buffers[i]));



More information about the Bf-blender-cvs mailing list