[Bf-blender-cvs] [a40a2690621] blender-v3.2-release: Fix (studio-reported) bad re-assigning of new liboverride from ID template widget.

Bastien Montagne noreply at git.blender.org
Tue May 24 15:04:25 CEST 2022


Commit: a40a26906213c2730c8b2efd9a509e18c7821e87
Author: Bastien Montagne
Date:   Tue May 24 15:03:04 2022 +0200
Branches: blender-v3.2-release
https://developer.blender.org/rBa40a26906213c2730c8b2efd9a509e18c7821e87

Fix (studio-reported) bad re-assigning of new liboverride from ID template widget.

Shift-click on the 'linked' button in an ID template widget would fail
to properly remap that usage of the linked ID to the newly created
liboverride.

===================================================================

M	source/blender/editors/interface/interface_templates.c

===================================================================

diff --git a/source/blender/editors/interface/interface_templates.c b/source/blender/editors/interface/interface_templates.c
index 4e6437e043a..c6e5deb314e 100644
--- a/source/blender/editors/interface/interface_templates.c
+++ b/source/blender/editors/interface/interface_templates.c
@@ -812,8 +812,11 @@ static void template_id_liboverride_hierarchy_create(bContext *C,
     id_override->override_library->flag &= ~IDOVERRIDE_LIBRARY_FLAG_SYSTEM_DEFINED;
     *r_undo_push_label = "Make Library Override Hierarchy";
 
-    WM_event_add_notifier(C, NC_WINDOW, NULL);
-    DEG_relations_tag_update(bmain);
+    /* Given `idptr` is re-assigned to owner property by caller to ensure proper updates etc. Here
+     * we also use it to ensure remapping of the owner property from the linked data to the newly
+     * created liboverride (note that in theory this remapping has already been done by code
+     * above). */
+    RNA_id_pointer_create(id_override, idptr);
   }
 }



More information about the Bf-blender-cvs mailing list