[Bf-blender-cvs] [9450057b43c] master: Fix T96799: GPencil `weight_get` API cannot retrieve weights

Antonio Vazquez noreply at git.blender.org
Tue Mar 29 11:26:19 CEST 2022


Commit: 9450057b43cb278e6b8003f54ec0705dae599165
Author: Antonio Vazquez
Date:   Tue Mar 29 11:25:18 2022 +0200
Branches: master
https://developer.blender.org/rB9450057b43cb278e6b8003f54ec0705dae599165

Fix T96799: GPencil `weight_get` API cannot retrieve weights

The problem was when the stroke had less weights that the total number of vertex groups.

The API checked the total number of groups, but this is not required because `BKE_defvert_find_index` returns NULL is the vertex group index does not exist.

===================================================================

M	source/blender/makesrna/intern/rna_gpencil.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_gpencil.c b/source/blender/makesrna/intern/rna_gpencil.c
index ba94fbe88e5..aa17f6bc366 100644
--- a/source/blender/makesrna/intern/rna_gpencil.c
+++ b/source/blender/makesrna/intern/rna_gpencil.c
@@ -848,10 +848,10 @@ static float rna_GPencilStrokePoints_weight_get(bGPDstroke *stroke,
   }
 
   MDeformVert *pt_dvert = stroke->dvert + point_index;
-  if ((pt_dvert) && (pt_dvert->totweight <= vertex_group_index || vertex_group_index < 0)) {
-    BKE_report(reports, RPT_ERROR, "Groups: index out of range");
-    return -1.0f;
-  }
+  // if ((pt_dvert) && (pt_dvert->totweight <= vertex_group_index || vertex_group_index < 0)) {
+  //   BKE_report(reports, RPT_ERROR, "Groups: index out of range");
+  //   return -1.0f;
+  // }
 
   MDeformWeight *dw = BKE_defvert_find_index(pt_dvert, vertex_group_index);
   if (dw) {



More information about the Bf-blender-cvs mailing list