[Bf-blender-cvs] [9ed63ebb458] master: Fix T96572: eevee crash with motion blur and stereoscopy

Jacques Lucke noreply at git.blender.org
Mon Mar 21 10:05:53 CET 2022


Commit: 9ed63ebb458141661bcbfe81c187f843e9dcbacf
Author: Jacques Lucke
Date:   Mon Mar 21 10:05:39 2022 +0100
Branches: master
https://developer.blender.org/rB9ed63ebb458141661bcbfe81c187f843e9dcbacf

Fix T96572: eevee crash with motion blur and stereoscopy

This was a use-after-free bug due to dangling pointers.

===================================================================

M	source/blender/draw/engines/eevee/eevee_data.c

===================================================================

diff --git a/source/blender/draw/engines/eevee/eevee_data.c b/source/blender/draw/engines/eevee/eevee_data.c
index 253981d321b..ee70cebcfd2 100644
--- a/source/blender/draw/engines/eevee/eevee_data.c
+++ b/source/blender/draw/engines/eevee/eevee_data.c
@@ -104,10 +104,12 @@ void EEVEE_motion_blur_data_free(EEVEE_MotionBlurData *mb)
   for (int i = 0; i < 2; i++) {
     if (mb->position_vbo_cache[i]) {
       BLI_ghash_free(mb->position_vbo_cache[i], NULL, (GHashValFreeFP)GPU_vertbuf_discard);
+      mb->position_vbo_cache[i] = NULL;
     }
     if (mb->hair_motion_step_cache[i]) {
       BLI_ghash_free(
           mb->hair_motion_step_cache[i], NULL, (GHashValFreeFP)EEVEE_motion_hair_step_free);
+      mb->hair_motion_step_cache[i] = NULL;
     }
   }
 }



More information about the Bf-blender-cvs mailing list