[Bf-blender-cvs] [39c070ed8f7] master: Fix T96229: GN Fillet Node unexpected limit radius behavior for 3 point splines

Dilith Jayakody noreply at git.blender.org
Sat Mar 12 05:51:22 CET 2022


Commit: 39c070ed8f7fb57bf1297177a391b853f33ba59d
Author: Dilith Jayakody
Date:   Fri Mar 11 18:37:55 2022 +0530
Branches: master
https://developer.blender.org/rB39c070ed8f7fb57bf1297177a391b853f33ba59d

Fix T96229: GN Fillet Node unexpected limit radius behavior for 3 point splines

This commit fixes T96229.

The maximum possible radius was being used for 3 point
splines, regardless of the current radius.

Reviewed By: HooglyBoogly

Maniphest Tasks: T96229

Differential Revision: https://developer.blender.org/D14311

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc b/source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc
index 0b01efc4e9e..81ca87eec25 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc
@@ -283,7 +283,7 @@ static void limit_radii(FilletData &fd, const bool cyclic)
 
   /* Assign the max_radii to the fillet data's radii. */
   for (const int i : IndexRange(size)) {
-    radii[i] = max_radii[i];
+    radii[i] = std::min(radii[i], max_radii[i]);
   }
 }



More information about the Bf-blender-cvs mailing list