[Bf-blender-cvs] [1d902a6367d] blender-v3.1-release: Fix T96213: Crash when texture painting across multiple materials.

Jeroen Bakker noreply at git.blender.org
Tue Mar 8 10:38:39 CET 2022


Commit: 1d902a6367d1d18670ed75e3508cd0db00021350
Author: Jeroen Bakker
Date:   Tue Mar 8 10:38:13 2022 +0100
Branches: blender-v3.1-release
https://developer.blender.org/rB1d902a6367d1d18670ed75e3508cd0db00021350

Fix T96213: Crash when texture painting across multiple materials.

Issue only happens in release builds on windows. That said it was an
actual error in the code. This class is compiled inline in release
builds. When updating multiple textures it would reuse the same memory
to collect the changes. When the previous loaded tilenumber was exactly the
same but from a different image the tile buffer wasn't loaded.

Reviewed By: sergey

Maniphest Tasks: T96213

Differential Revision: https://developer.blender.org/D14274

===================================================================

M	source/blender/blenkernel/BKE_image_partial_update.hh

===================================================================

diff --git a/source/blender/blenkernel/BKE_image_partial_update.hh b/source/blender/blenkernel/BKE_image_partial_update.hh
index ca7c4f40593..b00ec98353c 100644
--- a/source/blender/blenkernel/BKE_image_partial_update.hh
+++ b/source/blender/blenkernel/BKE_image_partial_update.hh
@@ -227,7 +227,7 @@ template<typename TileData = NoTileData> struct PartialUpdateChecker {
     ePartialUpdateCollectResult result_code;
 
    private:
-    TileNumber last_tile_number;
+    TileNumber last_tile_number = 0;
 
    public:
     CollectResult(PartialUpdateChecker<TileData> *checker, ePartialUpdateCollectResult result_code)



More information about the Bf-blender-cvs mailing list