[Bf-blender-cvs] [585d81ba2b7] master: Workbench: Increase render tests fail threshold for hair.

Jeroen Bakker noreply at git.blender.org
Fri Jun 24 14:11:47 CEST 2022


Commit: 585d81ba2b77371bf7ada99e7d4bab8bfd7be52f
Author: Jeroen Bakker
Date:   Fri Jun 24 14:09:15 2022 +0200
Branches: master
https://developer.blender.org/rB585d81ba2b77371bf7ada99e7d4bab8bfd7be52f

Workbench: Increase render tests fail threshold for hair.

When running the render test cases on MacOS/Intel the hair render
test fail. Most likely due to the dense geometry and the low
resolution of the test image.

This patch increases the fail threshold so these tests will pass.
Note that I haven't been able to test whether this is also the case
for Linux/Windows. If that is the case we should remove the platform
specific test.

===================================================================

M	tests/python/workbench_render_tests.py

===================================================================

diff --git a/tests/python/workbench_render_tests.py b/tests/python/workbench_render_tests.py
index 3ceb0fb3226..e182b2a41e2 100644
--- a/tests/python/workbench_render_tests.py
+++ b/tests/python/workbench_render_tests.py
@@ -3,10 +3,12 @@
 
 import argparse
 import os
+import platform
 import shlex
 import shutil
 import subprocess
 import sys
+from pathlib import Path
 
 
 def setup():
@@ -73,6 +75,11 @@ def main():
     report.set_pixelated(True)
     report.set_reference_dir("workbench_renders")
     report.set_compare_engine('eevee')
+
+    test_dir_name = Path(test_dir).name
+    if test_dir_name.startswith('hair') and platform.system() == "Darwin":
+        report.set_fail_threshold(0.050)
+
     ok = report.run(test_dir, blender, get_arguments, batch=True)
 
     sys.exit(not ok)



More information about the Bf-blender-cvs mailing list