[Bf-blender-cvs] [d83a418c456] master: Fix T98727: Dynamic Paint does not update normals

Philipp Oeser noreply at git.blender.org
Fri Jun 10 10:55:15 CEST 2022


Commit: d83a418c456cdfd8ce4629e4e2fc7c7a0ed253c3
Author: Philipp Oeser
Date:   Fri Jun 10 10:31:44 2022 +0200
Branches: master
https://developer.blender.org/rBd83a418c456cdfd8ce4629e4e2fc7c7a0ed253c3

Fix T98727: Dynamic Paint does not update normals

Caused by {rB6a3c3c77b3eb}.

Displacement and wave were tagging the original mesh normals dirty,
instead the result's normals need tagging. Seems like a typo in above
commit (similar to rBfe43c170831f).

Maniphest Tasks: T98727

Differential Revision: https://developer.blender.org/D15165

===================================================================

M	source/blender/blenkernel/intern/dynamicpaint.c

===================================================================

diff --git a/source/blender/blenkernel/intern/dynamicpaint.c b/source/blender/blenkernel/intern/dynamicpaint.c
index 48f2d66c1cd..e5bb70f8cda 100644
--- a/source/blender/blenkernel/intern/dynamicpaint.c
+++ b/source/blender/blenkernel/intern/dynamicpaint.c
@@ -2024,13 +2024,13 @@ static Mesh *dynamicPaint_Modifier_apply(DynamicPaintModifierData *pmd, Object *
             settings.use_threading = (sData->total_points > 1000);
             BLI_task_parallel_range(
                 0, sData->total_points, &data, dynamic_paint_apply_surface_wave_cb, &settings);
-            BKE_mesh_normals_tag_dirty(mesh);
+            BKE_mesh_normals_tag_dirty(result);
           }
 
           /* displace */
           if (surface->type == MOD_DPAINT_SURFACE_T_DISPLACE) {
             dynamicPaint_applySurfaceDisplace(surface, result);
-            BKE_mesh_normals_tag_dirty(mesh);
+            BKE_mesh_normals_tag_dirty(result);
           }
         }
       }



More information about the Bf-blender-cvs mailing list