[Bf-blender-cvs] [17971b8a5be] master: Fix: Heap buffer overflow in new curves set type node

[Hans Goudey]

Commit: 17971b8a5be8779e26621b24efa09893cdccb112
Author: Hans Goudey
Date:   Wed Jun 8 16:16:45 2022 +0200
Branches: master
https://developer.blender.org/rB17971b8a5be8779e26621b24efa09893cdccb112

Fix: Heap buffer overflow in new curves set type node

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc b/source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc
index 6c95ab3bdc9..0a4078772b9 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc
@@ -566,11 +566,9 @@ static void convert_to_nurbs(const CurveComponent &src_component,
     /* Avoid using "Endpoint" knots modes for cyclic curves, since it adds a sharp point at the
      * start/end. */
     if (src_cyclic.is_single()) {
-      bke::curves::fill_points<int8_t>(dst_curves,
-                                       selection,
-                                       src_cyclic.get_internal_single() ? NURBS_KNOT_MODE_NORMAL :
-                                                                          NURBS_KNOT_MODE_ENDPOINT,
-                                       dst_curves.nurbs_knots_modes_for_write());
+      dst_curves.nurbs_knots_modes_for_write().fill_indices(
+          selection,
+          src_cyclic.get_internal_single() ? NURBS_KNOT_MODE_NORMAL : NURBS_KNOT_MODE_ENDPOINT);
     }
     else {
       VArray_Span<bool> cyclic{src_cyclic};