[Bf-blender-cvs] [3063d90cfc0] master: Fix T99453: Regression: Crash on calling menu search

Pratik Borhade noreply at git.blender.org
Thu Jul 7 15:25:17 CEST 2022


Commit: 3063d90cfc057b4e1f269fd0723abbc0f2ae12f0
Author: Pratik Borhade
Date:   Thu Jul 7 15:23:41 2022 +0200
Branches: master
https://developer.blender.org/rB3063d90cfc057b4e1f269fd0723abbc0f2ae12f0

Fix T99453: Regression: Crash on calling menu search

Fix T99453.
Crash due to null pointer access.
So wrap the function call in simple `if` check

Reviewed By: sybren

Maniphest Tasks: T99453

Differential Revision: https://developer.blender.org/D15370

===================================================================

M	source/blender/editors/object/object_vgroup.c

===================================================================

diff --git a/source/blender/editors/object/object_vgroup.c b/source/blender/editors/object/object_vgroup.c
index 158bc28662a..17b7fe7fe5e 100644
--- a/source/blender/editors/object/object_vgroup.c
+++ b/source/blender/editors/object/object_vgroup.c
@@ -732,8 +732,10 @@ const EnumPropertyItem *ED_object_vgroup_selection_itemf_helper(const bContext *
   }
 
   /* Set `Deform Bone` as default selection if armature is present. */
-  RNA_def_property_enum_default(
-      prop, BKE_modifiers_is_deformed_by_armature(ob) ? WT_VGROUP_BONE_DEFORM : WT_VGROUP_ALL);
+  if (ob) {
+    RNA_def_property_enum_default(
+        prop, BKE_modifiers_is_deformed_by_armature(ob) ? WT_VGROUP_BONE_DEFORM : WT_VGROUP_ALL);
+  }
 
   RNA_enum_item_end(&item, &totitem);
   *r_free = true;



More information about the Bf-blender-cvs mailing list