[Bf-blender-cvs] [9a4927031da] master: Cleanup: Remove redundant filtering of legacy normal attribute

Hans Goudey noreply at git.blender.org
Thu Jul 7 15:15:38 CEST 2022


Commit: 9a4927031dade70e2fac42a5003ab4a21bfb9e3d
Author: Hans Goudey
Date:   Thu Jul 7 08:15:29 2022 -0500
Branches: master
https://developer.blender.org/rB9a4927031dade70e2fac42a5003ab4a21bfb9e3d

Cleanup: Remove redundant filtering of legacy normal attribute

This is already done inside of `attribute_search_add_items`.

===================================================================

M	source/blender/editors/space_node/node_geometry_attribute_search.cc

===================================================================

diff --git a/source/blender/editors/space_node/node_geometry_attribute_search.cc b/source/blender/editors/space_node/node_geometry_attribute_search.cc
index f08e23c8371..e328a86b0fd 100644
--- a/source/blender/editors/space_node/node_geometry_attribute_search.cc
+++ b/source/blender/editors/space_node/node_geometry_attribute_search.cc
@@ -113,14 +113,6 @@ static void attribute_search_update_fn(
 
   Vector<const GeometryAttributeInfo *> infos = get_attribute_info_from_context(*C, *data);
 
-  /* Remove the deprecated normal attribute from the search. */
-  for (const int i : infos.index_range()) {
-    if (infos[i]->domain == ATTR_DOMAIN_FACE && infos[i]->name == "normal") {
-      infos.remove(i);
-      break;
-    }
-  }
-
   ui::attribute_search_add_items(str, true, infos, items, is_first);
 }



More information about the Bf-blender-cvs mailing list