[Bf-blender-cvs] [67861003134] blender-v2.83-release: Fix T93130: Frame Selected with selected paint mask does not work

Philipp Oeser noreply at git.blender.org
Mon Jan 17 15:56:41 CET 2022


Commit: 678610031345457966fdacbea1b956c14ad3bba3
Author: Philipp Oeser
Date:   Tue Nov 16 20:25:11 2021 +0100
Branches: blender-v2.83-release
https://developer.blender.org/rB678610031345457966fdacbea1b956c14ad3bba3

Fix T93130: Frame Selected with selected paint mask does not work

This broke with {rB20fac2eca723} (which landed in 2.63), so long
standing bug.

Convention for paint modes is:
- when no paint mask is active, `Frame Selected` will focus the last
stroke
- when paint mask is active, `Frame Selected` will focus the selected
mask faces

To check the right vert coords we have to offset with `mp->loopstart`.

Maniphest Tasks: T93130

Differential Revision: https://developer.blender.org/D13247

===================================================================

M	source/blender/editors/mesh/editface.c

===================================================================

diff --git a/source/blender/editors/mesh/editface.c b/source/blender/editors/mesh/editface.c
index b303c4c7e4e..215a1e5e929 100644
--- a/source/blender/editors/mesh/editface.c
+++ b/source/blender/editors/mesh/editface.c
@@ -370,7 +370,7 @@ bool paintface_minmax(Object *ob, float r_min[3], float r_max[3])
       continue;
     }
 
-    ml = me->mloop + mp->totloop;
+    ml = me->mloop + mp->loopstart;
     for (b = 0; b < mp->totloop; b++, ml++) {
       mul_v3_m3v3(vec, bmat, mvert[ml->v].co);
       add_v3_v3v3(vec, vec, ob->obmat[3]);



More information about the Bf-blender-cvs mailing list