[Bf-blender-cvs] [ad1f8a50b02] master: Cleanup: Use C++ math functions

Hans Goudey noreply at git.blender.org
Mon Feb 14 22:48:54 CET 2022


Commit: ad1f8a50b02652e52e44ef06e24d2825c677be4e
Author: Hans Goudey
Date:   Mon Feb 14 15:48:46 2022 -0600
Branches: master
https://developer.blender.org/rBad1f8a50b02652e52e44ef06e24d2825c677be4e

Cleanup: Use C++ math functions

Use functions from the `math` and `std` namespaces instead
of from `BLI_math_vector.h`.

===================================================================

M	source/blender/blenlib/intern/noise.cc

===================================================================

diff --git a/source/blender/blenlib/intern/noise.cc b/source/blender/blenlib/intern/noise.cc
index 27e074fc3c1..24af186c1d5 100644
--- a/source/blender/blenlib/intern/noise.cc
+++ b/source/blender/blenlib/intern/noise.cc
@@ -581,7 +581,7 @@ float perlin_fractal(float4 position, float octaves, float roughness)
  * positions to act as a seed since the noise functions don't have seed values.
  * The offset's components are in the range [100, 200], not too high to cause
  * bad precision and not too small to be noticeable. We use float seed because
- * OSL only support float hashes and we need to maintain compatibility with it.
+ * OSL only supports float hashes and we need to maintain compatibility with it.
  */
 
 BLI_INLINE float random_float_offset(float seed)
@@ -727,7 +727,7 @@ float musgrave_fBm(const float co,
   float p = co;
   float value = 0.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
   for (int i = 0; i < (int)octaves; i++) {
@@ -752,7 +752,7 @@ float musgrave_multi_fractal(const float co,
   float p = co;
   float value = 1.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
   for (int i = 0; i < (int)octaves; i++) {
@@ -776,11 +776,11 @@ float musgrave_hetero_terrain(const float co,
                               const float offset)
 {
   float p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
-  /* first unscaled octave of function; later octaves are scaled */
+  /* First unscaled octave of function; later octaves are scaled. */
   float value = offset + perlin_signed(p);
   p *= lacunarity;
 
@@ -808,7 +808,7 @@ float musgrave_hybrid_multi_fractal(const float co,
                                     const float gain)
 {
   float p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
   float value = perlin_signed(p) + offset;
@@ -845,10 +845,10 @@ float musgrave_ridged_multi_fractal(const float co,
                                     const float gain)
 {
   float p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
-  float signal = offset - fabsf(perlin_signed(p));
+  float signal = offset - std::abs(perlin_signed(p));
   signal *= signal;
   float value = signal;
   float weight = 1.0f;
@@ -858,7 +858,7 @@ float musgrave_ridged_multi_fractal(const float co,
   for (int i = 1; i < (int)octaves; i++) {
     p *= lacunarity;
     weight = CLAMPIS(signal * gain, 0.0f, 1.0f);
-    signal = offset - fabsf(perlin_signed(p));
+    signal = offset - std::abs(perlin_signed(p));
     signal *= signal;
     signal *= weight;
     value += signal * pwr;
@@ -878,7 +878,7 @@ float musgrave_fBm(const float2 co,
   float2 p = co;
   float value = 0.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
   for (int i = 0; i < (int)octaves; i++) {
@@ -903,7 +903,7 @@ float musgrave_multi_fractal(const float2 co,
   float2 p = co;
   float value = 1.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
   for (int i = 0; i < (int)octaves; i++) {
@@ -927,10 +927,10 @@ float musgrave_hetero_terrain(const float2 co,
                               const float offset)
 {
   float2 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
-  /* first unscaled octave of function; later octaves are scaled */
+  /* First unscaled octave of function; later octaves are scaled. */
   float value = offset + perlin_signed(p);
   p *= lacunarity;
 
@@ -960,7 +960,7 @@ float musgrave_hybrid_multi_fractal(const float2 co,
                                     const float gain)
 {
   float2 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
   float value = perlin_signed(p) + offset;
@@ -997,10 +997,10 @@ float musgrave_ridged_multi_fractal(const float2 co,
                                     const float gain)
 {
   float2 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
-  float signal = offset - fabsf(perlin_signed(p));
+  float signal = offset - std::abs(perlin_signed(p));
   signal *= signal;
   float value = signal;
   float weight = 1.0f;
@@ -1010,7 +1010,7 @@ float musgrave_ridged_multi_fractal(const float2 co,
   for (int i = 1; i < (int)octaves; i++) {
     p *= lacunarity;
     weight = CLAMPIS(signal * gain, 0.0f, 1.0f);
-    signal = offset - fabsf(perlin_signed(p));
+    signal = offset - std::abs(perlin_signed(p));
     signal *= signal;
     signal *= weight;
     value += signal * pwr;
@@ -1030,7 +1030,7 @@ float musgrave_fBm(const float3 co,
   float3 p = co;
   float value = 0.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
 
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
@@ -1056,7 +1056,7 @@ float musgrave_multi_fractal(const float3 co,
   float3 p = co;
   float value = 1.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
 
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
@@ -1081,7 +1081,7 @@ float musgrave_hetero_terrain(const float3 co,
                               const float offset)
 {
   float3 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
   /* first unscaled octave of function; later octaves are scaled */
@@ -1114,7 +1114,7 @@ float musgrave_hybrid_multi_fractal(const float3 co,
                                     const float gain)
 {
   float3 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
   float value = perlin_signed(p) + offset;
@@ -1151,10 +1151,10 @@ float musgrave_ridged_multi_fractal(const float3 co,
                                     const float gain)
 {
   float3 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
-  float signal = offset - fabsf(perlin_signed(p));
+  float signal = offset - std::abs(perlin_signed(p));
   signal *= signal;
   float value = signal;
   float weight = 1.0f;
@@ -1164,7 +1164,7 @@ float musgrave_ridged_multi_fractal(const float3 co,
   for (int i = 1; i < (int)octaves; i++) {
     p *= lacunarity;
     weight = CLAMPIS(signal * gain, 0.0f, 1.0f);
-    signal = offset - fabsf(perlin_signed(p));
+    signal = offset - std::abs(perlin_signed(p));
     signal *= signal;
     signal *= weight;
     value += signal * pwr;
@@ -1184,7 +1184,7 @@ float musgrave_fBm(const float4 co,
   float4 p = co;
   float value = 0.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
 
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
@@ -1210,7 +1210,7 @@ float musgrave_multi_fractal(const float4 co,
   float4 p = co;
   float value = 1.0f;
   float pwr = 1.0f;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
 
   const float octaves = CLAMPIS(octaves_unclamped, 0.0f, 15.0f);
 
@@ -1235,7 +1235,7 @@ float musgrave_hetero_terrain(const float4 co,
                               const float offset)
 {
   float4 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
   /* first unscaled octave of function; later octaves are scaled */
@@ -1268,7 +1268,7 @@ float musgrave_hybrid_multi_fractal(const float4 co,
                                     const float gain)
 {
   float4 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
   float value = perlin_signed(p) + offset;
@@ -1305,10 +1305,10 @@ float musgrave_ridged_multi_fractal(const float4 co,
                                     const float gain)
 {
   float4 p = co;
-  const float pwHL = powf(lacunarity, -H);
+  const float pwHL = std::pow(lacunarity, -H);
   float pwr = pwHL;
 
-  float signal = offset - fabsf(perlin_signed(p));
+  float signal = offset - std::abs(perlin_signed(p));
   signal *= signal;
   float value = signal;
   float weight = 1.0f;
@@ -1318,7 +1318,7 @@ float musgrave_ridged_multi_fractal(const float4 co,
   for (int i = 1; i < (int)octaves; i++) {
     p *= lacunarity;
     weight = CLAMPIS(signal * gain, 0.0f, 1.0f);
-    signal = offset - fabsf(perlin_signed(p));
+    signal = offset - std::abs(perlin_signed(p));
     signal *= signal;
     signal *= weight;
     value += signal * pwr;
@@ -1362,7 +1362,7 @@ enum {
 
 BLI_INLINE float voronoi_distance(const float a, const float b)
 {
-  return fabsf(b - a);
+  return std::abs(b - a);
 }
 
 void voronoi_f1(
@@ -1491,10 +1491,10 @@ void voronoi_distance_to_edge(const float w, const float randomness, float *r_di
   const float midPointPosition = hash_float_to_float(cellPosition) * randomness;
   const float leftPointPosition = -1.0f + hash_float_to_float(cellPosition - 1.0f) * randomness;
   const float rightPointPosition = 1.0f + hash_float_to_float(cellPosition + 1.0f) * randomness;
-  const float distanceToMidLeft = fabsf((midPointPosition + leftPointPosition) / 2.0f -
-                                        localPosition);
-  const float distanceToMidRight = fabsf((midPointPosition + rightPointPosition) / 2.0f -
-                                         localPosition);
+  const float distanceToMidLeft = std::abs((midPointPosition + leftP

@@ Diff output truncated at 10240 characters. @@



More information about the Bf-blender-cvs mailing list