[Bf-blender-cvs] [6ae08da5c8a] blender-v3.1-release: Fix T95756: Crash inserting geometry node after linking modifier

Sergey Sharybin noreply at git.blender.org
Mon Feb 14 18:31:08 CET 2022


Commit: 6ae08da5c8a1b39cfba0c8c3bd567321d0768f28
Author: Sergey Sharybin
Date:   Mon Feb 14 18:19:13 2022 +0100
Branches: blender-v3.1-release
https://developer.blender.org/rB6ae08da5c8a1b39cfba0c8c3bd567321d0768f28

Fix T95756: Crash inserting geometry node after linking modifier

The root issue was caused by a mistake in modifier copy data which was
wrongly re-generating source modifier data identifier.

The c8cca8885181 simply exposed a bug in code which always was there
since the modifiers session UUID was introduced.

Shows an importance of const qualifier :)

===================================================================

M	source/blender/blenkernel/intern/modifier.c

===================================================================

diff --git a/source/blender/blenkernel/intern/modifier.c b/source/blender/blenkernel/intern/modifier.c
index 4f170535d18..d2fadbbd8ac 100644
--- a/source/blender/blenkernel/intern/modifier.c
+++ b/source/blender/blenkernel/intern/modifier.c
@@ -391,7 +391,7 @@ void BKE_modifier_copydata_ex(ModifierData *md, ModifierData *target, const int
   }
   else {
     /* In the case copyData made full byte copy force UUID to be re-generated. */
-    BKE_modifier_session_uuid_generate(md);
+    BKE_modifier_session_uuid_generate(target);
   }
 }



More information about the Bf-blender-cvs mailing list