[Bf-blender-cvs] [f3c58c65054] master: Cycles: Removed redundant/buggy code in multiscatter BSDF

Stefan Werner noreply at git.blender.org
Fri Feb 11 23:43:37 CET 2022


Commit: f3c58c65054fb3b0c0c09ede249c71fb4dd2c62e
Author: Stefan Werner
Date:   Wed Feb 9 11:22:32 2022 +0100
Branches: master
https://developer.blender.org/rBf3c58c65054fb3b0c0c09ede249c71fb4dd2c62e

Cycles: Removed redundant/buggy code in multiscatter BSDF

A zero length vector was normalized and the resulting NaN used in further calculations.
This caused trouble on some compilers when using fast math.

Reviewed By: brecht, sergey

Differential Revision: https://developer.blender.org/D14058

===================================================================

M	intern/cycles/kernel/closure/bsdf_microfacet_multi_impl.h

===================================================================

diff --git a/intern/cycles/kernel/closure/bsdf_microfacet_multi_impl.h b/intern/cycles/kernel/closure/bsdf_microfacet_multi_impl.h
index 8820f672862..e4fcf0e6ba3 100644
--- a/intern/cycles/kernel/closure/bsdf_microfacet_multi_impl.h
+++ b/intern/cycles/kernel/closure/bsdf_microfacet_multi_impl.h
@@ -193,9 +193,6 @@ ccl_device_forceinline float3 MF_FUNCTION_FULL_NAME(mf_sample)(float3 wi,
   bool outside = true;
 
   float F0 = fresnel_dielectric_cos(1.0f, eta);
-  if (use_fresnel) {
-    throughput = interpolate_fresnel_color(wi, normalize(wi + wr), eta, F0, cspec0);
-  }
 
   int order;
   for (order = 0; order < 10; order++) {



More information about the Bf-blender-cvs mailing list