[Bf-blender-cvs] [af5a9b5748d] temp-nodes-group-declarations: Improve comments in various places
Hans Goudey
noreply at git.blender.org
Thu Dec 22 20:42:36 CET 2022
Commit: af5a9b5748d7f21e2e995f870d23ec25e6a2a698
Author: Hans Goudey
Date: Thu Dec 22 14:42:17 2022 -0500
Branches: temp-nodes-group-declarations
https://developer.blender.org/rBaf5a9b5748d7f21e2e995f870d23ec25e6a2a698
Improve comments in various places
===================================================================
M source/blender/editors/space_node/node_group.cc
M source/blender/nodes/NOD_node_declaration.hh
===================================================================
diff --git a/source/blender/editors/space_node/node_group.cc b/source/blender/editors/space_node/node_group.cc
index beaf206dff7..05e54cf6bff 100644
--- a/source/blender/editors/space_node/node_group.cc
+++ b/source/blender/editors/space_node/node_group.cc
@@ -933,7 +933,7 @@ static void node_group_make_insert_selected(const bContext &C,
}
nodeRebuildIDVector(&ntree);
- /* Update the input and output node first, since the group node declaration depends on them. */
+ /* Update input and output node first, since the group node declaration can depend on them. */
nodes::update_node_declaration_and_sockets(group, *input_node);
nodes::update_node_declaration_and_sockets(group, *output_node);
nodes::update_node_declaration_and_sockets(ntree, *gnode);
diff --git a/source/blender/nodes/NOD_node_declaration.hh b/source/blender/nodes/NOD_node_declaration.hh
index f2523823e5e..27c5001da6a 100644
--- a/source/blender/nodes/NOD_node_declaration.hh
+++ b/source/blender/nodes/NOD_node_declaration.hh
@@ -311,6 +311,9 @@ class NodeDeclaration {
Vector<SocketDeclarationPtr> inputs_;
Vector<SocketDeclarationPtr> outputs_;
+ /** Leave the sockets in place, even if they don't match the declaration. Used for dynamic
+ * declarations when the information used to build the declaration is missing, but might become
+ * available again in the future. */
bool skip_updating_sockets = false;
friend NodeDeclarationBuilder;
More information about the Bf-blender-cvs
mailing list