[Bf-blender-cvs] [21a8d7c69b8] temp-nodes-group-declarations: Fix shader socket declaration

Hans Goudey noreply at git.blender.org
Thu Dec 22 20:39:59 CET 2022


Commit: 21a8d7c69b85f7c145513b6ef3d91b61ee734651
Author: Hans Goudey
Date:   Thu Dec 22 14:39:53 2022 -0500
Branches: temp-nodes-group-declarations
https://developer.blender.org/rB21a8d7c69b85f7c145513b6ef3d91b61ee734651

Fix shader socket declaration

Copy and paste error. All tests pass now

===================================================================

M	source/blender/nodes/intern/node_common.cc

===================================================================

diff --git a/source/blender/nodes/intern/node_common.cc b/source/blender/nodes/intern/node_common.cc
index e2712e59895..a81f5d463b7 100644
--- a/source/blender/nodes/intern/node_common.cc
+++ b/source/blender/nodes/intern/node_common.cc
@@ -154,7 +154,7 @@ static SocketDeclarationPtr declataion_for_interface_socket(const bNodeSocket &i
       break;
     }
     case SOCK_SHADER: {
-      std::unique_ptr<decl::Color> decl = std::make_unique<decl::Color>();
+      std::unique_ptr<decl::Shader> decl = std::make_unique<decl::Shader>();
       dst = std::move(decl);
       break;
     }
@@ -223,8 +223,8 @@ void node_group_declare_dynamic(const bNodeTree & /*node_tree*/,
     r_declaration.skip_updating_sockets = true;
     return;
   }
+  r_declaration.skip_updating_sockets = false;
 
-  /* TODO: Specialize for geometry nodes and fields. */
   /* TODO: Figure out how this should work for custom node trees / #SOCK_CUSTOM. */
   LISTBASE_FOREACH (const bNodeSocket *, input, &group->inputs) {
     r_declaration.inputs_.append(declataion_for_interface_socket(*input));



More information about the Bf-blender-cvs mailing list