[Bf-blender-cvs] [c80ff8a39db] microfacet_hair: Add comments to normal computations

Weizhen Huang noreply at git.blender.org
Thu Dec 22 15:21:55 CET 2022


Commit: c80ff8a39db4e2f30b447d48fa6585235d938450
Author: Weizhen Huang
Date:   Thu Dec 22 15:21:39 2022 +0100
Branches: microfacet_hair
https://developer.blender.org/rBc80ff8a39db4e2f30b447d48fa6585235d938450

Add comments to normal computations

===================================================================

M	intern/cycles/blender/curves.cpp

===================================================================

diff --git a/intern/cycles/blender/curves.cpp b/intern/cycles/blender/curves.cpp
index 3b1ccbc8c45..48cee230770 100644
--- a/intern/cycles/blender/curves.cpp
+++ b/intern/cycles/blender/curves.cpp
@@ -926,6 +926,8 @@ static void export_hair_curves(Scene *scene,
     float3 prev_co = zero_float3();
     float length = 0.0f;
 
+    /* TODO: It seems a waste of time to compute the normals of the subdivided curve, but only use
+     * those of the control points. Maybe the API of `evaluated_normals()` should be changed. */
     const int resolution = resolutions[i];
     const int evaluated_offset = evaluated_offsets[i];



More information about the Bf-blender-cvs mailing list