[Bf-blender-cvs] [d0348bcb8a5] master: Fix: Crash when grouping frame node but not its children

Hans Goudey noreply at git.blender.org
Wed Dec 21 19:29:08 CET 2022


Commit: d0348bcb8a560f3a5526fc2ad97e4211144c277e
Author: Hans Goudey
Date:   Tue Dec 20 16:30:11 2022 -0600
Branches: master
https://developer.blender.org/rBd0348bcb8a560f3a5526fc2ad97e4211144c277e

Fix: Crash when grouping frame node but not its children

Most likely caused by ab4926bcffeef20cfb9225d

===================================================================

M	source/blender/editors/space_node/node_group.cc

===================================================================

diff --git a/source/blender/editors/space_node/node_group.cc b/source/blender/editors/space_node/node_group.cc
index 2c28a8fae34..45aeaa41ad5 100644
--- a/source/blender/editors/space_node/node_group.cc
+++ b/source/blender/editors/space_node/node_group.cc
@@ -833,7 +833,7 @@ static void node_group_make_insert_selected(const bContext &C,
     if (node->parent == nullptr) {
       continue;
     }
-    if (nodes_to_move.contains(node->parent) && nodes_to_move.contains(node)) {
+    if (nodes_to_move.contains(node->parent) && !nodes_to_move.contains(node)) {
       nodeDetachNode(&ntree, node);
     }
   }



More information about the Bf-blender-cvs mailing list