[Bf-blender-cvs] [f613614fceb] master: Fix T103136: Cannot activate viewer node in group

Hans Goudey noreply at git.blender.org
Tue Dec 13 23:45:51 CET 2022


Commit: f613614fcebf4dd769abd0d2cfb72fe95ff7bc4c
Author: Hans Goudey
Date:   Tue Dec 13 16:42:06 2022 -0600
Branches: master
https://developer.blender.org/rBf613614fcebf4dd769abd0d2cfb72fe95ff7bc4c

Fix T103136: Cannot activate viewer node in group

90ea1b76434fe175e99 created an item for the viewer node path
but didn't add it to the list, which also caused memory leaks.

===================================================================

M	source/blender/editors/util/ed_viewer_path.cc

===================================================================

diff --git a/source/blender/editors/util/ed_viewer_path.cc b/source/blender/editors/util/ed_viewer_path.cc
index f0bbade6361..be569aa02fa 100644
--- a/source/blender/editors/util/ed_viewer_path.cc
+++ b/source/blender/editors/util/ed_viewer_path.cc
@@ -64,6 +64,7 @@ static void viewer_path_for_geometry_node(const SpaceNode &snode,
     NodeViewerPathElem *node_elem = BKE_viewer_path_elem_new_node();
     node_elem->node_id = node->identifier;
     node_elem->node_name = BLI_strdup(node->name);
+    BLI_addtail(&r_dst.path, node_elem);
   }
 
   NodeViewerPathElem *viewer_node_elem = BKE_viewer_path_elem_new_node();
@@ -111,7 +112,7 @@ void activate_geometry_node(Main &bmain, SpaceNode &snode, bNode &node)
       }
     }
 
-    /* Enable viewer in one viewport if it is disable in all of them. */
+    /* Enable viewer in one viewport if it is disabled in all of them. */
     if (!found_view3d_with_enabled_viewer && any_view3d_without_viewer != nullptr) {
       any_view3d_without_viewer->flag2 |= V3D_SHOW_VIEWER;
     }



More information about the Bf-blender-cvs mailing list