[Bf-blender-cvs] [bc73c1cd167] tmp-workbench-rewrite2: add TODO

Miguel Pozo noreply at git.blender.org
Mon Dec 12 12:34:52 CET 2022


Commit: bc73c1cd16740f3b8a5c9ba58ef50c190158a867
Author: Miguel Pozo
Date:   Mon Dec 5 19:12:58 2022 +0100
Branches: tmp-workbench-rewrite2
https://developer.blender.org/rBbc73c1cd16740f3b8a5c9ba58ef50c190158a867

add TODO

===================================================================

M	source/blender/draw/engines/workbench/workbench_shadow.cc

===================================================================

diff --git a/source/blender/draw/engines/workbench/workbench_shadow.cc b/source/blender/draw/engines/workbench/workbench_shadow.cc
index 61207337d86..3632cc54f5a 100644
--- a/source/blender/draw/engines/workbench/workbench_shadow.cc
+++ b/source/blender/draw/engines/workbench/workbench_shadow.cc
@@ -221,6 +221,10 @@ void ShadowPass::object_sync(Manager &manager,
       use_shadow_pass_technique = false;
     }
 
+    /* TODO (Miguel Pozo):
+     * Disable use_shadow_pass_tecnique when there are "in front" objects in the scene.
+     */
+
     /* We cannot use Shadow Pass technique on non-manifold object (see T76168). */
     if (use_shadow_pass_technique && !is_manifold && (scene_state.cull_state != 0)) {
       use_shadow_pass_technique = false;



More information about the Bf-blender-cvs mailing list