[Bf-blender-cvs] [49e8218edfc] geometry-nodes-simulation: Remove Started and Ended booleans

Hans Goudey noreply at git.blender.org
Sat Dec 10 07:01:25 CET 2022


Commit: 49e8218edfcefa6866f4d60fb64a35ad9d63f2f0
Author: Hans Goudey
Date:   Fri Dec 9 17:13:23 2022 -0600
Branches: geometry-nodes-simulation
https://developer.blender.org/rB49e8218edfcefa6866f4d60fb64a35ad9d63f2f0

Remove Started and Ended booleans

These aren't theoretically necessary, since you can just created them
as regular outputs. Maybe we will eventually add them back for
convenience, but that's not clear.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_simulation_output.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_simulation_output.cc b/source/blender/nodes/geometry/nodes/node_geo_simulation_output.cc
index 43d913163a1..295fb92d3f6 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_simulation_output.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_simulation_output.cc
@@ -19,8 +19,6 @@ static void node_declare(NodeDeclarationBuilder &b)
 {
   b.add_input<decl::Bool>(N_("Run")).default_value(true);
   b.add_input<decl::Geometry>(N_("Geometry"));
-  b.add_output<decl::Bool>(N_("Started"));
-  b.add_output<decl::Bool>(N_("Ended"));
   b.add_output<decl::Geometry>(N_("Geometry"));
 }
 
@@ -51,15 +49,6 @@ static void node_geo_exec(GeoNodeExecParams params)
 
   const float elapsed_time = cache.is_empty() ? 0.0f : scene_ctime - cache.start_time()->time;
   const bool run = params.get_input<bool>("Run");
-  const bool started = !cache.is_empty();
-  const bool ended = !cache.is_empty() && !run;
-
-  if (params.lazy_output_is_required("Started")) {
-    params.set_output("Started", started);
-  }
-  if (params.lazy_output_is_required("Ended")) {
-    params.set_output("Ended", ended);
-  }
 
   if (!run) {
     if (std::optional<GeometrySet> value = cache.value_at_or_before_time("Geometry", time)) {



More information about the Bf-blender-cvs mailing list