[Bf-blender-cvs] [26f66e14230] blender-v3.4-release: Revert "Sculpt: Register sculpt brush op so it clears last operator panel"

Campbell Barton noreply at git.blender.org
Tue Dec 6 03:47:25 CET 2022


Commit: 26f66e142306dd105e5cad6e9cd03057f1dfd31b
Author: Campbell Barton
Date:   Tue Dec 6 13:37:51 2022 +1100
Branches: blender-v3.4-release
https://developer.blender.org/rB26f66e142306dd105e5cad6e9cd03057f1dfd31b

Revert "Sculpt: Register sculpt brush op so it clears last operator panel"

This reverts commit 11bdc321a274712e5c5ae83ff2c199690f66ecf7.

This change caused T101743, in general OPTYPE_UNDO should not be used
to control the UI.

This also caused 2x undo pushes to be performed when sculpting,
although sculpt mode doesn't add a step for the second undo push
so it wasn't visible to the user.

An alternative fix will be applied separately as it's too risky this
close to a release.

===================================================================

M	source/blender/editors/sculpt_paint/sculpt.c

===================================================================

diff --git a/source/blender/editors/sculpt_paint/sculpt.c b/source/blender/editors/sculpt_paint/sculpt.c
index 212d39464b7..ed2fe83aae6 100644
--- a/source/blender/editors/sculpt_paint/sculpt.c
+++ b/source/blender/editors/sculpt_paint/sculpt.c
@@ -5863,7 +5863,7 @@ void SCULPT_OT_brush_stroke(wmOperatorType *ot)
   ot->ui = sculpt_redo_empty_ui;
 
   /* Flags (sculpt does own undo? (ton)). */
-  ot->flag = OPTYPE_BLOCKING | OPTYPE_REGISTER | OPTYPE_UNDO;
+  ot->flag = OPTYPE_BLOCKING;
 
   /* Properties. */



More information about the Bf-blender-cvs mailing list