[Bf-blender-cvs] [039f714aaf3] refactor-mesh-selection-generic: Cleanup

[Hans Goudey]

Commit: 039f714aaf32a11b15437425c64d9eda474b8dff
Author: Hans Goudey
Date:   Fri Aug 26 23:08:47 2022 -0500
Branches: refactor-mesh-selection-generic
https://developer.blender.org/rB039f714aaf32a11b15437425c64d9eda474b8dff

Cleanup

===================================================================

M	source/blender/editors/mesh/editface.cc
M	source/blender/editors/object/object_vgroup.cc
M	source/blender/editors/space_view3d/view3d_select.cc

===================================================================

diff --git a/source/blender/editors/mesh/editface.cc b/source/blender/editors/mesh/editface.cc
index 26144bba4b1..2a73da0cb16 100644
--- a/source/blender/editors/mesh/editface.cc
+++ b/source/blender/editors/mesh/editface.cc
@@ -414,7 +414,6 @@ bool paintface_mouse_select(bContext *C,
                             Object *ob)
 {
   using namespace blender;
-  MPoly *mpoly_sel = nullptr;
   uint index;
   bool changed = false;
   bool found = false;
@@ -430,7 +429,6 @@ bool paintface_mouse_select(bContext *C,
 
   if (ED_mesh_pick_face(C, ob, mval, ED_MESH_PICK_DEFAULT_FACE_DIST, &index)) {
     if (index < me->totpoly) {
-      mpoly_sel = me->mpoly + index;
       if (!hide_poly[index]) {
         found = true;
       }
diff --git a/source/blender/editors/object/object_vgroup.cc b/source/blender/editors/object/object_vgroup.cc
index e94c634c95e..a929f2599b1 100644
--- a/source/blender/editors/object/object_vgroup.cc
+++ b/source/blender/editors/object/object_vgroup.cc
@@ -670,7 +670,6 @@ static void vgroup_copy_active_to_sel(Object *ob, eVGroupSelect subset_type)
         ".selection_vert", ATTR_DOMAIN_POINT, false);
 
     MDeformVert *dv;
-
     int v_act;
 
     dvert_act = ED_mesh_active_dvert_get_ob(ob, &v_act);
@@ -2462,7 +2461,6 @@ void ED_vgroup_mirror(Object *ob,
     }
     else {
       /* object mode / weight paint */
-      MVert *mv;
       int vidx, vidx_mirr;
       const bool use_vert_sel = (me->editflag & ME_EDIT_PAINT_VERT_SEL) != 0;
 
@@ -2480,7 +2478,7 @@ void ED_vgroup_mirror(Object *ob,
       const VArray<bool> selection_vert = attributes.lookup_or_default<bool>(
           ".selection_vert", ATTR_DOMAIN_POINT, false);
 
-      for (vidx = 0, mv = me->mvert; vidx < me->totvert; vidx++, mv++) {
+      for (vidx = 0; vidx < me->totvert; vidx++) {
         if (!BLI_BITMAP_TEST(vert_tag, vidx)) {
           if ((vidx_mirr = mesh_get_x_mirror_vert(ob, nullptr, vidx, use_topology)) != -1) {
             if (vidx != vidx_mirr) {
diff --git a/source/blender/editors/space_view3d/view3d_select.cc b/source/blender/editors/space_view3d/view3d_select.cc
index 63bc9efe6be..081e1613cb6 100644
--- a/source/blender/editors/space_view3d/view3d_select.cc
+++ b/source/blender/editors/space_view3d/view3d_select.cc
@@ -3469,7 +3469,8 @@ static bool do_mesh_box_select(ViewContext *vc,
   }
   if (ts->selectmode & SCE_SELECT_EDGE) {
     /* Does both use_zbuf and non-use_zbuf versions (need screen cos for both) */
-    struct BoxSelectUserData_ForMeshEdge cb_data {};
+    struct BoxSelectUserData_ForMeshEdge cb_data {
+    };
     cb_data.data = &data;
     cb_data.esel = use_zbuf ? esel : nullptr;
     cb_data.backbuf_offset = use_zbuf ? DRW_select_buffer_context_offset_for_object_elem(