[Bf-blender-cvs] [f36d8d59c25] master: Cleanup: remove redundant calculation in bmo_poke_exec
Campbell Barton
noreply at git.blender.org
Thu Aug 25 07:15:13 CEST 2022
Commit: f36d8d59c255e627ef981000fde197cf2be84b73
Author: Campbell Barton
Date: Thu Aug 25 14:58:50 2022 +1000
Branches: master
https://developer.blender.org/rBf36d8d59c255e627ef981000fde197cf2be84b73
Cleanup: remove redundant calculation in bmo_poke_exec
Mistake in [0] calculated the mean-face-center which wasn't used.
0: 23344bca6c5d1de330169a04ed8d21145fc60053
===================================================================
M source/blender/bmesh/operators/bmo_poke.c
===================================================================
diff --git a/source/blender/bmesh/operators/bmo_poke.c b/source/blender/bmesh/operators/bmo_poke.c
index 7ff3b9b072c..05f13a161b1 100644
--- a/source/blender/bmesh/operators/bmo_poke.c
+++ b/source/blender/bmesh/operators/bmo_poke.c
@@ -53,7 +53,7 @@ void bmo_poke_exec(BMesh *bm, BMOperator *op)
BMO_ITER (f, &oiter, op->slots_in, "faces", BM_FACE) {
BMFace *f_new;
- float f_center[3], f_center_mean[3];
+ float f_center[3];
BMVert *v_center = NULL;
BMLoop *l_iter, *l_first;
/* only interpolate the central loop from the face once,
@@ -69,15 +69,6 @@ void bmo_poke_exec(BMesh *bm, BMOperator *op)
v_center = BM_vert_create(bm, f_center, NULL, BM_CREATE_NOP);
BMO_vert_flag_enable(bm, v_center, ELE_NEW);
- if (cd_loop_mdisp_offset != -1) {
- if (center_mode == BMOP_POKE_MEDIAN) {
- copy_v3_v3(f_center_mean, f_center);
- }
- else {
- BM_face_calc_center_median(f, f_center_mean);
- }
- }
-
/* handled by BM_loop_interp_from_face */
// BM_vert_interp_from_face(bm, v_center, f);
More information about the Bf-blender-cvs
mailing list