[Bf-blender-cvs] [46cf16fba6e] temp-eevee-next-cryptomatte: Fix storing multiple samples.

Jeroen Bakker noreply at git.blender.org
Wed Aug 24 12:15:31 CEST 2022


Commit: 46cf16fba6e8db902bdea59e7b4c9a5a18ac5c0d
Author: Jeroen Bakker
Date:   Wed Aug 24 10:31:16 2022 +0200
Branches: temp-eevee-next-cryptomatte
https://developer.blender.org/rB46cf16fba6e8db902bdea59e7b4c9a5a18ac5c0d

Fix storing multiple samples.

===================================================================

M	source/blender/draw/engines/eevee_next/shaders/eevee_cryptomatte_lib.glsl

===================================================================

diff --git a/source/blender/draw/engines/eevee_next/shaders/eevee_cryptomatte_lib.glsl b/source/blender/draw/engines/eevee_next/shaders/eevee_cryptomatte_lib.glsl
index 7b9a75387b4..1284d5e84c6 100644
--- a/source/blender/draw/engines/eevee_next/shaders/eevee_cryptomatte_lib.glsl
+++ b/source/blender/draw/engines/eevee_next/shaders/eevee_cryptomatte_lib.glsl
@@ -8,6 +8,7 @@ bool can_merge_cryptomatte_sample(vec2 cryptomatte_sample, float hash)
   if (cryptomatte_sample.x == hash) {
     return true;
   }
+  return false;
 }
 
 vec2 merge_cryptomatte_sample(vec2 cryptomatte_sample, float hash, float weight)
@@ -44,7 +45,8 @@ void film_store_cryptomatte_sample(FilmSample dst,
       sample_pair.zw = merge_cryptomatte_sample(sample_pair.zw, hash, weight);
     }
     else if (i == film_buf.cryptomatte_samples_len / 2 - 1) {
-      // TODO: new hash, no space, we should compare/overwrite lowest sample.
+      // TODO(jbakker): New hash detected, but there is no space left to store it. Currently we
+      // will ignore this sample, but ideally we could replace a sample with a lowest weight.
       continue;
     }
     else {



More information about the Bf-blender-cvs mailing list