[Bf-blender-cvs] [923e10d7513] master: Fix: Crash if Movie Clip node has an empty movie

Omar Emara noreply at git.blender.org
Wed Aug 17 15:15:09 CEST 2022


Commit: 923e10d7513b53588a9b13888de1d958d5f6d57f
Author: Omar Emara
Date:   Wed Aug 17 15:11:35 2022 +0200
Branches: master
https://developer.blender.org/rB923e10d7513b53588a9b13888de1d958d5f6d57f

Fix: Crash if Movie Clip node has an empty movie

The movie clip GPU texture free function doesn't do null checks, so make
sure the movie clip is not null before freeing.

===================================================================

M	source/blender/nodes/composite/nodes/node_composite_movieclip.cc

===================================================================

diff --git a/source/blender/nodes/composite/nodes/node_composite_movieclip.cc b/source/blender/nodes/composite/nodes/node_composite_movieclip.cc
index ec95de3da18..7c1a61cedc4 100644
--- a/source/blender/nodes/composite/nodes/node_composite_movieclip.cc
+++ b/source/blender/nodes/composite/nodes/node_composite_movieclip.cc
@@ -247,7 +247,9 @@ class MovieClipOperation : public NodeOperation {
   void free_movie_clip_texture()
   {
     MovieClip *movie_clip = get_movie_clip();
-    return BKE_movieclip_free_gputexture(movie_clip);
+    if (movie_clip) {
+      BKE_movieclip_free_gputexture(movie_clip);
+    }
   }
 
   MovieClip *get_movie_clip()



More information about the Bf-blender-cvs mailing list