[Bf-blender-cvs] [b1d3097fa9f] master: WM: update comment about window redraw for thumbnails

Campbell Barton noreply at git.blender.org
Wed Aug 17 08:04:02 CEST 2022


Commit: b1d3097fa9fd1085304bc476d065a42f5c1d524a
Author: Campbell Barton
Date:   Wed Aug 17 15:56:00 2022 +1000
Branches: master
https://developer.blender.org/rBb1d3097fa9fd1085304bc476d065a42f5c1d524a

WM: update comment about window redraw for thumbnails

===================================================================

M	source/blender/windowmanager/intern/wm_files.c

===================================================================

diff --git a/source/blender/windowmanager/intern/wm_files.c b/source/blender/windowmanager/intern/wm_files.c
index 1819ed13be3..cbf492fc582 100644
--- a/source/blender/windowmanager/intern/wm_files.c
+++ b/source/blender/windowmanager/intern/wm_files.c
@@ -1768,9 +1768,11 @@ static bool wm_file_write(bContext *C,
   /* Enforce full override check/generation on file save. */
   BKE_lib_override_library_main_operations_create(bmain, true);
 
-  /* NOTE: Ideally we would call `WM_redraw_windows` here to remove any open menus. But we
-   * can crash if saving from a script, see T92704 & T97627. Just checking `!G.background
-   * && BLI_thread_is_main()` is not sufficient to fix this. */
+  /* NOTE: Ideally we would call `WM_redraw_windows` here to remove any open menus.
+   * But we can crash if saving from a script, see T92704 & T97627.
+   * Just checking `!G.background && BLI_thread_is_main()` is not sufficient to fix this.
+   * Additionally some some EGL configurations don't support reading the front-buffer
+   * immediately after drawing, see: T98462. In that case off-screen drawing is necessary. */
 
   /* don't forget not to return without! */
   WM_cursor_wait(true);



More information about the Bf-blender-cvs mailing list