[Bf-blender-cvs] [9da0cfb86ee] master: Python: Add more useful information when attempting to pass incorrect attributes to GPUVertBuf.attr_fill

Colin Basnett noreply at git.blender.org
Fri Aug 5 01:01:35 CEST 2022


Commit: 9da0cfb86ee098b9172da69bb43703aa2efba691
Author: Colin Basnett
Date:   Thu Aug 4 15:51:54 2022 -0700
Branches: master
https://developer.blender.org/rB9da0cfb86ee098b9172da69bb43703aa2efba691

Python: Add more useful information when attempting to pass incorrect attributes to GPUVertBuf.attr_fill

This simply adds the name of the incorrect parameter to the error message.

Differential Revision: https://developer.blender.org/D14103

Reviewed by Jeroen Bakker

===================================================================

M	source/blender/python/gpu/gpu_py_vertex_buffer.c

===================================================================

diff --git a/source/blender/python/gpu/gpu_py_vertex_buffer.c b/source/blender/python/gpu/gpu_py_vertex_buffer.c
index ac050128a1d..ab2ff59a689 100644
--- a/source/blender/python/gpu/gpu_py_vertex_buffer.c
+++ b/source/blender/python/gpu/gpu_py_vertex_buffer.c
@@ -292,7 +292,7 @@ static PyObject *pygpu_vertbuf_attr_fill(BPyGPUVertBuf *self, PyObject *args, Py
     const char *name = PyUnicode_AsUTF8(identifier);
     id = GPU_vertformat_attr_id_get(format, name);
     if (id == -1) {
-      PyErr_SetString(PyExc_ValueError, "Unknown attribute name");
+      PyErr_Format(PyExc_ValueError, "Unknown attribute '%s'", name);
       return NULL;
     }
   }



More information about the Bf-blender-cvs mailing list