[Bf-blender-cvs] [ead8260a49d] blender-v3.3-release: Object: move collection resync after empty duplicate early-out

Aras Pranckevicius noreply at git.blender.org
Tue Aug 2 20:01:31 CEST 2022


Commit: ead8260a49debaeb69967b2b4d2b62bf97333328
Author: Aras Pranckevicius
Date:   Tue Aug 2 21:01:09 2022 +0300
Branches: blender-v3.3-release
https://developer.blender.org/rBead8260a49debaeb69967b2b4d2b62bf97333328

Object: move collection resync after empty duplicate early-out

As pointed out in rB02b1a209be88 comment, the BKE_main_collection_sync
should be after "nothing to duplicate" early-out.

===================================================================

M	source/blender/editors/object/object_add.cc

===================================================================

diff --git a/source/blender/editors/object/object_add.cc b/source/blender/editors/object/object_add.cc
index 55366348f38..acd7a8e3c13 100644
--- a/source/blender/editors/object/object_add.cc
+++ b/source/blender/editors/object/object_add.cc
@@ -3715,14 +3715,15 @@ static int duplicate_exec(bContext *C, wmOperator *op)
     }
   }
   CTX_DATA_END;
-  /* Sync the collection now, after everything is duplicated. */
   BKE_layer_collection_resync_allow();
-  BKE_main_collection_sync(bmain);
 
   if (source_bases_new_objects.is_empty()) {
     return OPERATOR_CANCELLED;
   }
 
+  /* Sync the collection now, after everything is duplicated. */
+  BKE_main_collection_sync(bmain);
+
   /* After sync we can get to the new Base data, process it here. */
   for (const auto &item : source_bases_new_objects) {
     Object *ob_new = item.second;



More information about the Bf-blender-cvs mailing list