[Bf-blender-cvs] [cfce5a32a7d] master: Fix a failing bmesh_bevel test by fixing buffer overflow.

Howard Trickey noreply at git.blender.org
Sat Apr 23 04:41:24 CEST 2022


Commit: cfce5a32a7d8bf2479bbaf338b963c8e85efe9fd
Author: Howard Trickey
Date:   Fri Apr 22 22:39:05 2022 -0400
Branches: master
https://developer.blender.org/rBcfce5a32a7d8bf2479bbaf338b963c8e85efe9fd

Fix a failing bmesh_bevel test by fixing buffer overflow.

The uv fix just submitted had a bug where I forgot to wrap around
after adding 1. This apparently worked anyway in a debug build
but not in release build, hence the buildbot tests were failing.

===================================================================

M	source/blender/bmesh/tools/bmesh_bevel.c

===================================================================

diff --git a/source/blender/bmesh/tools/bmesh_bevel.c b/source/blender/bmesh/tools/bmesh_bevel.c
index e5006c2672c..1c184b1ae6e 100644
--- a/source/blender/bmesh/tools/bmesh_bevel.c
+++ b/source/blender/bmesh/tools/bmesh_bevel.c
@@ -5409,8 +5409,9 @@ static void snap_edges_for_vmesh_vert(int i,
     }
     else if (jj == ns2 && kk == ns2 + 1) {
       /* Center poly vert for boundvert i+1. */
+      int nexti = (i + 1) % n_bndv;
       r_snap_edges[corner] = snap_edge_for_center_vmesh_vert(
-          i + 1, n_bndv, enext, enextnext, bndv_rep_faces, center_frep, frep_beats_next);
+          nexti, n_bndv, enext, enextnext, bndv_rep_faces, center_frep, frep_beats_next);
     }
   }
 }



More information about the Bf-blender-cvs mailing list