[Bf-blender-cvs] [ee9688da997] master: Cleanup: redundant logical not

Germano Cavalcante noreply at git.blender.org
Tue Apr 12 15:04:51 CEST 2022


Commit: ee9688da997fc6e7d7aece39d5da23c99618dc21
Author: Germano Cavalcante
Date:   Tue Apr 12 10:02:01 2022 -0300
Branches: master
https://developer.blender.org/rBee9688da997fc6e7d7aece39d5da23c99618dc21

Cleanup: redundant logical not

Overlooked at rB0ebcc711f.

The logical not in this case was only applied to the left hand side of
the comparison.

===================================================================

M	source/blender/blenkernel/intern/camera.c

===================================================================

diff --git a/source/blender/blenkernel/intern/camera.c b/source/blender/blenkernel/intern/camera.c
index 3897df9f05f..32925168437 100644
--- a/source/blender/blenkernel/intern/camera.c
+++ b/source/blender/blenkernel/intern/camera.c
@@ -698,12 +698,12 @@ static bool camera_frame_fit_calc_from_data(CameraParams *params,
     add_v3_v3v3(plane_isect_1_other, plane_isect_1, plane_isect_1_no);
     add_v3_v3v3(plane_isect_2_other, plane_isect_2, plane_isect_2_no);
 
-    if (!isect_line_line_v3(plane_isect_1,
-                            plane_isect_1_other,
-                            plane_isect_2,
-                            plane_isect_2_other,
-                            plane_isect_pt_1,
-                            plane_isect_pt_2) != 0) {
+    if (isect_line_line_v3(plane_isect_1,
+                           plane_isect_1_other,
+                           plane_isect_2,
+                           plane_isect_2_other,
+                           plane_isect_pt_1,
+                           plane_isect_pt_2) == 0) {
       return false;
     }



More information about the Bf-blender-cvs mailing list