[Bf-blender-cvs] [328dfab4236] master: Fix T97003: color-management settings can't be animated

Campbell Barton noreply at git.blender.org
Tue Apr 5 13:07:35 CEST 2022


Commit: 328dfab4236ac56a36969335df795e80cba08188
Author: Campbell Barton
Date:   Tue Apr 5 20:58:50 2022 +1000
Branches: master
https://developer.blender.org/rB328dfab4236ac56a36969335df795e80cba08188

Fix T97003: color-management settings can't be animated

Regression in [0] which missed excluding FRAME_CHANGE from
deg_recalc_flags_for_legacy_zero causing all
DEG_id_tag_update(&scene->id, 0) calls to re-calculate animation data.

When this tagging was done in the RNA update function, changing
key-framed values in the UI would be immediate reset to their
keyed-values.

Thanks to Philipp Oeser for finding the root cause.

[0]: 35aedd87e78d44aa0a622d26261ecac7ece12925

===================================================================

M	source/blender/depsgraph/intern/depsgraph_tag.cc

===================================================================

diff --git a/source/blender/depsgraph/intern/depsgraph_tag.cc b/source/blender/depsgraph/intern/depsgraph_tag.cc
index f945e9b6fbc..b50081458ad 100644
--- a/source/blender/depsgraph/intern/depsgraph_tag.cc
+++ b/source/blender/depsgraph/intern/depsgraph_tag.cc
@@ -445,8 +445,8 @@ const char *update_source_as_string(eUpdateSource source)
 
 int deg_recalc_flags_for_legacy_zero()
 {
-  return ID_RECALC_ALL &
-         ~(ID_RECALC_PSYS_ALL | ID_RECALC_ANIMATION | ID_RECALC_SOURCE | ID_RECALC_EDITORS);
+  return ID_RECALC_ALL & ~(ID_RECALC_PSYS_ALL | ID_RECALC_ANIMATION | ID_RECALC_FRAME_CHANGE |
+                           ID_RECALC_SOURCE | ID_RECALC_EDITORS);
 }
 
 int deg_recalc_flags_effective(Depsgraph *graph, int flags)



More information about the Bf-blender-cvs mailing list