[Bf-blender-cvs] [1584a054db5] cycles_oneapi: Cleanup: Remove a commented source code in the oneAPI implementation

Nikita Sirgienko noreply at git.blender.org
Fri Apr 1 01:07:34 CEST 2022


Commit: 1584a054db58f81f5722dd315d040b762de0aaf4
Author: Nikita Sirgienko
Date:   Thu Mar 31 23:44:23 2022 +0200
Branches: cycles_oneapi
https://developer.blender.org/rB1584a054db58f81f5722dd315d040b762de0aaf4

Cleanup: Remove a commented source code in the oneAPI implementation

No functional changes.

===================================================================

M	intern/cycles/device/oneapi/device.cpp
M	intern/cycles/kernel/device/oneapi/kernel.cpp

===================================================================

diff --git a/intern/cycles/device/oneapi/device.cpp b/intern/cycles/device/oneapi/device.cpp
index 9d1d7384871..ffdb79534ee 100644
--- a/intern/cycles/device/oneapi/device.cpp
+++ b/intern/cycles/device/oneapi/device.cpp
@@ -146,11 +146,6 @@ static void device_iterator_cb(const char *id, const char *name, int num, void *
 
   // NOTE(sirgienko) Seems not possible to know from SYCL/oneAPI or Level0.
   info.display_device = false;
-  /*
-  info.description += " (Display)";
-  info.display_device = true;
-  display_devices.push_back(info);
-  */
 
   devices->push_back(info);
   VLOG(1) << "Added device \"" << name << "\" with id \"" << info.id << "\".";
diff --git a/intern/cycles/kernel/device/oneapi/kernel.cpp b/intern/cycles/kernel/device/oneapi/kernel.cpp
index 18ae5249646..ee8c90e096b 100644
--- a/intern/cycles/kernel/device/oneapi/kernel.cpp
+++ b/intern/cycles/kernel/device/oneapi/kernel.cpp
@@ -212,32 +212,8 @@ bool oneapi_trigger_runtime_compilation(SyclQueue *queue_)
 
 bool oneapi_kernel_globals_size(SyclQueue *queue_, size_t &kernel_global_size)
 {
-  // NOTE(sirgienko) No need to trigger JIT compilation/recompilation yet
-  /*
-  sycl::buffer<size_t> output(1);
-
-  try {
-    queue->submit([&](sycl::handler &cgh) {
-      sycl::accessor acc(output, cgh, sycl::write_only, sycl::no_init);
-
-      cgh.single_task([=]() { acc[0] = sizeof(KernelGlobalsGPU); });
-    });
-    queue->wait_and_throw();
-  }
-  catch (sycl::exception const &e) {
-    if (s_error_cb) {
-      s_error_cb(e.what(), s_error_user_ptr);
-    }
-    return false;
-  }
-
-  sycl::host_accessor acc(output, sycl::read_only);
-  kernel_global_size = acc[0];
-  */
   kernel_global_size = sizeof(KernelGlobalsGPU);
 
-  // assert(sizeof(KernelGlobalsGPU) == kernel_global_size);
-
   return true;
 }



More information about the Bf-blender-cvs mailing list