[Bf-blender-cvs] [43167a2c251] master: Fix T90570: Constraint validity not updated with library overrides.

Bastien Montagne noreply at git.blender.org
Mon Sep 27 15:34:04 CEST 2021


Commit: 43167a2c251b8388be3dc4d2460913f41de13c49
Author: Bastien Montagne
Date:   Mon Sep 27 15:08:28 2021 +0200
Branches: master
https://developer.blender.org/rB43167a2c251b8388be3dc4d2460913f41de13c49

Fix T90570: Constraint validity not updated with library overrides.

For some reason was assuming setting a property in RNA would call its
update callback if any, but this actually needs to be done separately.

So add this call to `rna_property_override_operation_apply`.

===================================================================

M	source/blender/makesrna/intern/rna_access_compare_override.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_access_compare_override.c b/source/blender/makesrna/intern/rna_access_compare_override.c
index f8a36c1b2e6..be8972dbff3 100644
--- a/source/blender/makesrna/intern/rna_access_compare_override.c
+++ b/source/blender/makesrna/intern/rna_access_compare_override.c
@@ -614,20 +614,25 @@ static bool rna_property_override_operation_apply(Main *bmain,
   }
 
   /* get and set the default values as appropriate for the various types */
-  return override_apply(bmain,
-                        ptr_dst,
-                        ptr_src,
-                        ptr_storage,
-                        prop_dst,
-                        prop_src,
-                        prop_storage,
-                        len_dst,
-                        len_src,
-                        len_storage,
-                        ptr_item_dst,
-                        ptr_item_src,
-                        ptr_item_storage,
-                        opop);
+  const bool sucess = override_apply(bmain,
+                                     ptr_dst,
+                                     ptr_src,
+                                     ptr_storage,
+                                     prop_dst,
+                                     prop_src,
+                                     prop_storage,
+                                     len_dst,
+                                     len_src,
+                                     len_storage,
+                                     ptr_item_dst,
+                                     ptr_item_src,
+                                     ptr_item_storage,
+                                     opop);
+  if (sucess) {
+    RNA_property_update_main(bmain, NULL, ptr_dst, prop_dst);
+  }
+
+  return sucess;
 }
 
 /**



More information about the Bf-blender-cvs mailing list