[Bf-blender-cvs] [2a0db195c90] master: Fix viewport roll working wrong

Philipp Oeser noreply at git.blender.org
Mon Sep 27 14:24:41 CEST 2021


Commit: 2a0db195c90d786beee34a8c3693063d2826d299
Author: Philipp Oeser
Date:   Mon Sep 27 13:46:55 2021 +0200
Branches: master
https://developer.blender.org/rB2a0db195c90d786beee34a8c3693063d2826d299

Fix viewport roll working wrong

Mistake in own {rB69893ef27c91}.
Was mixing screen on region coordinates.

===================================================================

M	source/blender/editors/space_view3d/view3d_edit.c

===================================================================

diff --git a/source/blender/editors/space_view3d/view3d_edit.c b/source/blender/editors/space_view3d/view3d_edit.c
index aced0ac3a6e..d917674194a 100644
--- a/source/blender/editors/space_view3d/view3d_edit.c
+++ b/source/blender/editors/space_view3d/view3d_edit.c
@@ -4523,10 +4523,9 @@ static int viewroll_invoke(bContext *C, wmOperator *op, const wmEvent *event)
     viewops_data_alloc(C, op);
     viewops_data_create(C, op, event, viewops_flag_from_prefs());
     vod = op->customdata;
-    vod->init.dial = BLI_dial_init(
-        (const float[2]){(vod->region->winrct.xmax - vod->region->winrct.xmin) / 2,
-                         (vod->region->winrct.ymax - vod->region->winrct.ymin) / 2},
-        FLT_EPSILON);
+    vod->init.dial = BLI_dial_init((const float[2]){BLI_rcti_cent_x(&vod->region->winrct),
+                                                    BLI_rcti_cent_y(&vod->region->winrct)},
+                                   FLT_EPSILON);
 
     ED_view3d_smooth_view_force_finish(C, vod->v3d, vod->region);



More information about the Bf-blender-cvs mailing list