[Bf-blender-cvs] [c7734438456] master: Fix: Incorrect default values for the curve trim node

Hans Goudey noreply at git.blender.org
Mon Sep 20 05:08:18 CEST 2021


Commit: c77344384567b4aad2e39691b2423f34306c963f
Author: Hans Goudey
Date:   Sun Sep 19 22:08:11 2021 -0500
Branches: master
https://developer.blender.org/rBc77344384567b4aad2e39691b2423f34306c963f

Fix: Incorrect default values for the curve trim node

The default end factor should be 1. The proper value for the default end
length is somewhat arbitrary, but it shouldn't be zero.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc b/source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc
index a90a7665ec7..2b6d25b6bf3 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc
@@ -30,9 +30,9 @@ static void geo_node_curve_trim_declare(NodeDeclarationBuilder &b)
 {
   b.add_input<decl::Geometry>("Curve");
   b.add_input<decl::Float>("Start").min(0.0f).max(1.0f).subtype(PROP_FACTOR);
-  b.add_input<decl::Float>("End").min(0.0f).max(1.0f).subtype(PROP_FACTOR);
+  b.add_input<decl::Float>("End").min(0.0f).max(1.0f).default_value(1.0f).subtype(PROP_FACTOR);
   b.add_input<decl::Float>("Start", "Start_001").min(0.0f).subtype(PROP_DISTANCE);
-  b.add_input<decl::Float>("End", "End_001").min(0.0f).subtype(PROP_DISTANCE);
+  b.add_input<decl::Float>("End", "End_001").min(0.0f).default_value(1.0f).subtype(PROP_DISTANCE);
   b.add_output<decl::Geometry>("Curve");
 }



More information about the Bf-blender-cvs mailing list